Allow large int64_t values in domain and extent to be printed (closes #464)#465
Merged
eddelbuettel merged 4 commits intomasterfrom Sep 6, 2022
Merged
Allow large int64_t values in domain and extent to be printed (closes #464)#465eddelbuettel merged 4 commits intomasterfrom
eddelbuettel merged 4 commits intomasterfrom
Conversation
eddelbuettel
requested review from
Shelnutt2,
aaronwolen,
awenocur and
ihnorton
|
This pull request has been linked to Shortcut Story #21241: Allow domain values in (u)int64 types outside of int32 ranges. |
awenocur
approved these changes
Sep 5, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR allows domain / dim values (and tile extent) in int64_t data types (and the datetime types using int64_t) to be displayed by the show() methods. Previously, large values were not returned and errored whereas smaller ones were returned as int. Now we return integer64 for the larger ones which R can handle.
No added code, but altered behavior dependent