Merged
Conversation
|
This pull request has been linked to Shortcut Story #22999: Integrate spdlog. |
awenocur
approved these changes
Oct 28, 2022
5e50ca4 to
699e230
Compare
Contributor
Author
|
Did one more round of tests and am now quite positive this works as intended -- giving us |
a30e6f3 to
6014704
Compare
ihnorton
approved these changes
Nov 10, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This (draft) PR adds support for spdlog.
On Windows, it is currently disabled as the linking withlibspdlog.a(to supportlibtiledb) creates an issue.Edit: This has been reworked, and the logging ability is now exported directly from the RcppSpdlog package. It requires a version that is slightly ahead of what CRAN has; CI is installing this explicitly right now.
Having this support allows to control logging both from the package and (via the standard config object) at the TileDB Core level:
The question to discuss now is whether a) this useful as-is on the two main OSs we use for development and b) whether it may be worth rejigging the core library build to export the logger (which would clearly be a more medium-term change).