Accomodate zero buffer size estimate#482
Merged
eddelbuettel merged 3 commits intomasterfrom Nov 10, 2022
Merged
Conversation
eddelbuettel
requested review from
KiterLuc,
Shelnutt2,
awenocur and
ihnorton
|
This pull request has been linked to Shortcut Story #23256: Accomodate zero estimate for buffer size on attributes added in schema evolution. |
Contributor
Author
|
The user confirmed on slack that his fix the issue (on read) as expected which may aid in the pending review. |
ihnorton
approved these changes
Nov 10, 2022
eddelbuettel
force-pushed
the
de/sc-23256/accomodate_zero_buffer_size_estimate
branch
from
7c4072c to
4be3322
Compare
Contributor
Author
|
Rebased, will await another CI run before merge. |
eddelbuettel
deleted the
de/sc-23256/accomodate_zero_buffer_size_estimate
branch
Merged
This was referenced Oct 25, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For attributes added under schema evolution, an estimated buffer size of zero can be returned from TileDB Embedded. The subsequent calculation for a 'best' buffer size to allocate before submitted a query does not deal gracefully with this, and this PR improves the calculation. It also protects two allocation size variables from overflow by passing them as double, this matters only if the user has set a very large memory allocation preference via the available setter function.