Merged
Conversation
|
This pull request has been linked to Shortcut Story #23877: Update valgrind job settings. |
awenocur
approved these changes
Dec 3, 2022
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The setup script for the nightly valgrind job still explicitly enumerates R package dependencies (as opposed to parsing the DESCRIPTION file information) and needs an update for the dependencies
spdlandRcppSpdlogadded in 0.17.0.At the same time we can also remove
Additonal_repositorieswhich was left in DESCRIPTION but is no longer needed.