Update tile_extent getter#577
Merged
eddelbuettel merged 2 commits intomasterfrom Jul 29, 2023
Merged
Conversation
|
This pull request has been linked to Shortcut Story #32283: Refine tile extent retrieval. |
awenocur
approved these changes
Jul 29, 2023
eddelbuettel
force-pushed
the
de/sc-32283/tile_extent
branch
from
8fa2ea0 to
a16ec70
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When accessing a VCF array it was observed that a perfectly valid uint32_t tile extent could not be retrieved to an existing and somewhat overly restrictive check in the extent getter. This PR updates it by switching to larger data types (with warning) as needed allowing processing of such arrays.
The PR also removes one filter test which cannot be applied to float data, this is unrelated to the change above and more likely to a change in TileDB Embedded.