Add release-2.19 branch, shared linkage, curl to nightly valgrind#635
Merged
eddelbuettel merged 1 commit intomasterfrom Dec 11, 2023
Merged
Add release-2.19 branch, shared linkage, curl to nightly valgrind#635eddelbuettel merged 1 commit intomasterfrom
eddelbuettel merged 1 commit intomasterfrom
Conversation
eddelbuettel
requested review from
Shelnutt2,
aaronwolen,
awenocur,
ihnorton and
johnkerl
|
This pull request has been linked to Shortcut Story #38175: Update valgrind nightly. |
eddelbuettel
changed the title
awenocur
approved these changes
Dec 11, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The nightly
valgrindjob needs a few minor updates to i) extend to release-2.19, and ii) repair build on dev by adding--linkage=sharedas well as thecurlbinary needed to keepvcpkghappy. Tested in a container.No new code, no new tests.