Correct one example, update roxygen2 use in two other spots#648
Merged
eddelbuettel merged 4 commits intomasterfrom Jan 16, 2024
Merged
Correct one example, update roxygen2 use in two other spots#648eddelbuettel merged 4 commits intomasterfrom
eddelbuettel merged 4 commits intomasterfrom
Conversation
eddelbuettel
requested review from
aaronwolen,
awenocur,
ihnorton,
johnkerl and
mojaveazure
awenocur
approved these changes
Jan 16, 2024
|
This pull request has been linked to Shortcut Story #39274: Integrate Academy into Cloud UI iframe and ensure it works on staging + review apps. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As #647 points out, the
fromDataFrame()example was a little stale and needed an update provided here.Using current
roxygen27.3.0 also leads to two changes: a correctly identified typo, and a forced change because that's how opinionated packages roll.