Skip to content

In a distant past we needed to avoid tests on Windows Server 2008 #673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
eddelbuettel merged 1 commit into from
Mar 18, 2024
Merged

In a distant past we needed to avoid tests on Windows Server 2008 #673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
31 changes: 11 additions & 20 deletions inst/tinytest/test_arrayschema.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)

ctx <- tiledb_ctx(limitTileDBCores())

if (get_return_as_preference() != "asis") set_return_as_preference("asis") # baseline value
Expand Down Expand Up @@ -97,28 +95,21 @@ expect_error(tiledb:::libtiledb_array_schema_set_capacity(sch@ptr, -10))


#test_that("tiledb_array_schema created with encryption", {
if (!(isOldWindows)) {
dir.create(uri <- tempfile())
key <- "0123456789abcdeF0123456789abcdeF"

dom <- tiledb_domain(dims = c(tiledb_dim("rows", c(1L, 4L), 4L, "INT32"),
tiledb_dim("cols", c(1L, 4L), 4L, "INT32")))
schema <- tiledb_array_schema(dom, attrs = c(tiledb_attr("a", type = "INT32")))
dir.create(uri <- tempfile())
key <- "0123456789abcdeF0123456789abcdeF"

##tiledb_array_create_with_key(uri, schema, key)
## for now calling into function
tiledb:::libtiledb_array_create_with_key(uri, schema@ptr, key)
dom <- tiledb_domain(dims = c(tiledb_dim("rows", c(1L, 4L), 4L, "INT32"),
tiledb_dim("cols", c(1L, 4L), 4L, "INT32")))
schema <- tiledb_array_schema(dom, attrs = c(tiledb_attr("a", type = "INT32")))

# ctx <- tiledb_ctx()
# arrptr <- tiledb:::libtiledb_array_open_with_key(ctx@ptr, uri, "WRITE", key)
# A <- new("tiledb_dense", ctx=ctx, uri=uri, as.data.frame=FALSE, ptr=arrptr)
##tiledb_array_create_with_key(uri, schema, key)
## for now calling into function
tiledb:::libtiledb_array_create_with_key(uri, schema@ptr, key)

# expect_true(is(A, "tiledb_dense"))
##expect_true(is(schema(A), "tiledb_dense"))
## can't yet read / write as scheme getter not generalized for encryption
##expect_true(is(schema(A), "tiledb_dense"))
## can't yet read / write as scheme getter not generalized for encryption

unlink(uri, recursive=TRUE)
}
unlink(uri, recursive=TRUE)
#})

#test_that("tiledb_array_schema dups setter/getter", {
Expand Down
1 change: 0 additions & 1 deletion inst/tinytest/test_arrayschemaevolution.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
library(tinytest)
library(tiledb)

#isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (Sys.info()[["sysname"]] == "Windows") exit_file("Skip on Windows")

ctx <- tiledb_ctx(limitTileDBCores())
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_arrowio.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

if (Sys.getenv("CI", "") == "") exit_file("Skip unextended test run")

ctx <- tiledb_ctx(limitTileDBCores())
Expand Down
2 changes: 0 additions & 2 deletions inst/tinytest/test_attr.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@ library(tiledb)

ctx <- tiledb_ctx(limitTileDBCores())

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
isWindows <- Sys.info()[["sysname"]] == "Windows"

#test_that("tiledb_attr constructor works", {
Expand Down Expand Up @@ -54,7 +53,6 @@ expect_true(is.na(tiledb::cell_val_num(attrs)))
#})

#test_that("tiledb_attr set fill", {
if (isOldWindows) exit_file("skip remainder of this file on old Windows releases")

## test for default
dom <- tiledb_domain(dims = tiledb_dim("rows", c(1L, 4L), 4L, "INT32"))
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_ctx.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

tiledb_ctx(limitTileDBCores())

#test_that("tiledb_ctx default constructor", {
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_dataframe.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

ctx <- tiledb_ctx(limitTileDBCores())

#test_that("tiledb_fromdataframe", {
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_datetime.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

isMacOS <- (Sys.info()['sysname'] == "Darwin")

ctx <- tiledb_ctx(limitTileDBCores())
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_dim.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

ctx <- tiledb_ctx(limitTileDBCores())

#test_that("tiledb_dim default constructor", {
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_dimsubset.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,9 +5,6 @@ library(tinytest)
library(tiledb)
library(RcppSpdlog) # use logging for some informal profiling

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

if (!requireNamespace("nycflights13", quietly=TRUE)) exit_file("Needed 'nycflights13' package missing")

log_setup("test_dimsubset", "warn") # but set the default level to 'warn' -> silent, activate via 'info'
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_domain.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

ctx <- tiledb_ctx(limitTileDBCores())

#test_that("tiledb_domain basic constructor", {
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_filestore.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

isWindows <- Sys.info()[["sysname"]] == "Windows"

ctx <- tiledb_ctx(limitTileDBCores())
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_filterlist.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

ctx <- tiledb_ctx(limitTileDBCores())

#test_that("tiledb_filter_list default constructor", {
Expand Down
2 changes: 0 additions & 2 deletions inst/tinytest/test_fragmentinfo.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")
isMacOS <- (Sys.info()['sysname'] == "Darwin")

ctx <- tiledb_ctx(limitTileDBCores())
Expand Down
2 changes: 0 additions & 2 deletions inst/tinytest/test_group.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")
isWindows <- Sys.info()[["sysname"]] == "Windows"
isMacOS <- (Sys.info()['sysname'] == "Darwin")

Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_libtiledb.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

tiledb_ctx(limitTileDBCores())

#test_that("version is valid", {
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_matrix.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

ctx <- tiledb_ctx(limitTileDBCores())

uri <- tempfile()
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_metadata.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

ctx <- tiledb_ctx(limitTileDBCores())

tmp <- tempfile()
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_misc.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,9 +2,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

ctx <- tiledb_ctx(limitTileDBCores())

if (is.null(get0("tiledb_error_message"))) exit_file("No 'tiledb_error_message'")
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_query.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

tiledb_ctx(limitTileDBCores())

.createArray <- function(tmp) {
Expand Down
2 changes: 0 additions & 2 deletions inst/tinytest/test_querycondition.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,7 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
isWindows <- Sys.info()[["sysname"]] == "Windows"
if (isOldWindows) exit_file("skip this file on old Windows releases")

#if (Sys.getenv("_RUNNING_UNDER_VALGRIND_", "FALSE") == "TRUE" && Sys.Date() < as.Date("2022-08-06")) exit_file("Skipping under valgrind until Aug 6")

Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_sparsematrix.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

ctx <- tiledb_ctx(limitTileDBCores())

if (!requireNamespace("Matrix", quietly=TRUE)) exit_file("Need the 'Matrix' package")
Expand Down
2 changes: 0 additions & 2 deletions inst/tinytest/test_tiledbarray.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")
isMacOS <- (Sys.info()['sysname'] == "Darwin")

ctx <- tiledb_ctx(limitTileDBCores())
Expand Down
3 changes: 1 addition & 2 deletions inst/tinytest/test_tiledbarray_extra.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,7 @@
library(tinytest)
library(tiledb)
exit_file("Skip for now")
isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

isMacOS <- (Sys.info()['sysname'] == "Darwin")
if (tiledb_version(TRUE) < "2.7.0") exit_file("Needs TileDB 2.7.* or later")

Expand Down
2 changes: 0 additions & 2 deletions inst/tinytest/test_timetravel.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")
isMacOS <- (Sys.info()['sysname'] == "Darwin")

ctx <- tiledb_ctx(limitTileDBCores())
Expand Down
2 changes: 0 additions & 2 deletions inst/tinytest/test_timetravel_extra.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,8 +2,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")
isMacOS <- (Sys.info()['sysname'] == "Darwin")

ctx <- tiledb_ctx(limitTileDBCores())
Expand Down
3 changes: 0 additions & 3 deletions inst/tinytest/test_vfs.R
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
library(tinytest)
library(tiledb)

isOldWindows <- Sys.info()[["sysname"]] == "Windows" && grepl('Windows Server 2008', osVersion)
if (isOldWindows) exit_file("skip this file on old Windows releases")

tiledb_ctx(limitTileDBCores())

#test_that("tiledb_vfs default constructor", {
Expand Down