feat: expose fail-on severity threshold in GitHub Action#82
Merged
Conversation
The --fail-on CLI flag (added in #77) was never wired into action.yml, so composite-action users had no way to control which severity level fails the workflow. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a configurable severity threshold to the Dolphin GitHub Action so users can choose which finding level (error/warning/info) should fail a workflow, matching the dolphin check --fail-on CLI behavior introduced in #77.
Changes:
- Adds a new
fail-oninput toaction.ymlwith defaulterror. - Passes the selected threshold through to the action’s
dolphin checkinvocation via--fail-on.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
fail-oninput toaction.yml(error/warning/info, defaulterror) mirroring the CLI's--fail-onflag added in feat: add --fail-on option to control failing severity #77dolphin checkinvocation so composite-action users can control which severity level fails the workflowTest plan
fail-on: warningin a downstream workflow and confirm it fails on warning-level findings🤖 Generated with Claude Code