Skip to content

Allow the user to define a custom bar button for done and cancel#87

Merged
skywinder merged 2 commits intoTimCinel:masterfrom
Citrrus:master
Jul 10, 2014
Merged

Allow the user to define a custom bar button for done and cancel#87
skywinder merged 2 commits intoTimCinel:masterfrom
Citrrus:master

Conversation

@MattCBowman
Copy link
Copy Markdown
Contributor

The bar button's target and action properties are weakly protected because they are overridden in the setters, but they could be changed after the fact if the user retains a handle to them.

@rhfung
Copy link
Copy Markdown

rhfung commented Jul 12, 2013

Would you like to explain how your solution is different and better than #82? Perhaps identifying a use case would be beneficial.

@MattCBowman
Copy link
Copy Markdown
Contributor Author

Hey Richard - the goal of this item was to allow additional control over the default cancel and done UIBarButtons. In our case, we wanted to use FontAwesome icons for the buttons, so we needed to set the font on the buttons, not just alter the text (as seen in #82).
After discussing it, our team decided that it would be a pain to try to make methods to support all of the customizations a user might want for the bar buttons, so we went for the more expedient route, allowing users to pass in their own UIBarButton. Here's an image of the result:

screen shot 2013-07-12 at 2 05 39 pm

@skywinder
Copy link
Copy Markdown
Collaborator

Please, remove Podspec file from pull request.

@ma2kubo
Copy link
Copy Markdown

ma2kubo commented May 26, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>
Subject: Re: [ActionSheetPicker] Allow the user to define a custom bar button for done and cancel (#87)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Copy Markdown
Collaborator

Before merge it needed to add example of new methods usage to README.md file.

Thank you.

@ma2kubo
Copy link
Copy Markdown

ma2kubo commented Jun 6, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>; ma2kubo <ma2kubo@gmail.com>
Subject: Re: [ActionSheetPicker] Allow the user to define a custom bar button for done and cancel (#87)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder
Copy link
Copy Markdown
Collaborator

Merged in skywinder/ActionSheetPicker-3.0@6e873f7

@ma2kubo
Copy link
Copy Markdown

ma2kubo commented Jul 10, 2014

Evernote was unable to submit your note for the following reason:

The emailed note was received, but Evernote did not understand the email address. It may have been mistyped, or the user may not exist. Please check to make sure the address was properly entered.

Original message information:
From: Petr Korolev <notifications@github.com>
Delivered To: deviceone.c1297@m.evernote.com
All recipients: TimCinel/ActionSheetPicker <ActionSheetPicker@noreply.github.com>; ma2kubo <ma2kubo@gmail.com>
Subject: Re: [ActionSheetPicker] Allow the user to define a custom bar button for done and cancel (#87)

To prevent excessive emails, you may not receive another error reply for the next 360 minutes.

  • The Evernote team

@skywinder skywinder merged commit 37494e1 into TimCinel:master Jul 10, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants