test: cover install and verify scripts#40
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: a59f80de09
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if extra_env: | ||
| env.update(extra_env) | ||
| proc = subprocess.Popen( | ||
| [BASH, str(script_path)], |
There was a problem hiding this comment.
Run install script tests as a non-root user
When pytest is run as root, which is common in Docker-based CI/dev containers, this launches install.sh with EUID=0. The script exits at its root guard before resolving BLITZTEXT_NO_HOTKEY or reaching the systemd setup, so all four install tests fail and only exercise the root check instead of the intended paths. Please run this subprocess under an unprivileged user or skip/xfail these install-script cases in root environments.
Useful? React with 👍 / 👎.
Summary
Adds subprocess-level regression coverage for the Linux install and verify scripts.
Covered
scripts/verify.sh
scripts/install.sh
Verification
Notes