chore: harden startup environment and simplify worker paths#41
Merged
Conversation
Der Pre-Check referenzierte self.config, das im Worker nicht existiert. Bei fehlendem API-Key sah der Nutzer dadurch einen AttributeError statt des Env-Var-Hinweises. LLMService.rewrite() meldet den fehlenden Key bereits selbst korrekt; der doppelte Check entfällt ersatzlos. Regressionstest deckt den Fehlerpfad ab.
ComposeWindow: _start_worker und _start_worker_raw teilten 13 Zeilen identisches QThread-Wiring; jetzt gemeinsamer _launch_worker-Helper. LLMService: dampf_ablassen, text_improver, emoji_text und rewrite_raw wiederholten denselben Completion-Aufruf inkl. Leerantwort-Check; jetzt gemeinsamer _chat_completion-Helper. Verhalten unverändert.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR combines one pre-existing local hardening commit with the reviewed Fable-5 simplification pass.
Pre-existing before Fable 5
56debb9—test: cover startup display environmentROADMAP.mdfrom the repositoryFable-5 simplification pass
9361265— removes a broken duplicated API-key pre-check from_TranscribeWorkerLLMServicereport its own missing-key message with the configured env-var name4c070f8— deduplicates worker thread wiring and chat-completion callsVerification
python3 -m compileall app testsQT_QPA_PLATFORM=offscreen WHISPER_GUI_TESTS=1 python -m pytest -qgit diff --checkgit status --shortgit ls-files ROADMAP.mdResult before push:
443 passedROADMAP.mdnot trackedScope
Not touched:
Merge note
Do not merge before CI is green and final approval is given.