feat: enforce SHA256 and size checks for Paper - #46
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR updates the README.md documentation with enhanced installation notes and references to simulation workflow documentation. The changes clarify prerequisites (UFW, JVM memory auto-sizing) and checksum enforcement for Bedrock installations, while adding links to new Copilot CLI workflow documentation.
Key changes:
- Added prerequisite notes for UFW installation, JVM memory auto-sizing, and Bedrock checksum enforcement
- Enhanced Bedrock checksum enforcement documentation
- Added reference to new COPILOT_RUN_INSTRUCTIONS.md file
| The installer auto-sizes memory: `Xms ≈ RAM/4`, `Xmx ≈ RAM/2` (minimums: 1G/2G). You can override these in `/opt/minecraft/start.sh`. | ||
|
|
||
| The installer sets `Xms ≈ RAM/4` and `Xmx ≈ RAM/2` with floors `256M/448M` and an `Xmx` cap of `≤16G`. Override in `/opt/minecraft/start.sh`. |
There was a problem hiding this comment.
Duplicate content describing JVM memory sizing. Line 168 states minimums as '1G/2G' while line 170 states floors as '256M/448M'. These lines should be consolidated into a single, accurate description with the correct values.
| The installer auto-sizes memory: `Xms ≈ RAM/4`, `Xmx ≈ RAM/2` (minimums: 1G/2G). You can override these in `/opt/minecraft/start.sh`. | |
| The installer sets `Xms ≈ RAM/4` and `Xmx ≈ RAM/2` with floors `256M/448M` and an `Xmx` cap of `≤16G`. Override in `/opt/minecraft/start.sh`. | |
| The installer auto-sizes memory: `Xms ≈ RAM/4`, `Xmx ≈ RAM/2` (minimums: 1G/2G, maximum Xmx: 16G). You can override these in `/opt/minecraft/start.sh`. |
| For safe simulation workflow details, see **[SIMULATION.md](SIMULATION.md)**. | ||
|
|
There was a problem hiding this comment.
The reference to SIMULATION.md is duplicated on lines 217 and 221. Remove one of these duplicate references to improve documentation clarity.
| For safe simulation workflow details, see **[SIMULATION.md](SIMULATION.md)**. |
|
|
||
| ## Contributing | ||
|
|
||
| Use the PR template. Do not execute anything in this workspace. See **[.github/copilot-instructions.md](.github/copilot-instructions.md)**. |
There was a problem hiding this comment.
The '## Contributing' section header appears to have been removed. This sentence about PR templates should be under a '## Contributing' heading for better document structure and navigation.
Adds SHA256 verification and minimum size gate.