fix(studio): TML-815 explain camera track takeover - #16
Merged
Conversation
Multica-Task: TML-815 Multica-Run: d18471e3-5eed-4ad0-ab3b-17f450e8fc3b Co-authored-by: multica-agent <github@multica.ai>
Multica-Task: TML-815 Multica-Run: dace7cab-5122-4064-b0a1-25fd24c237e7 Co-authored-by: multica-agent <github@multica.ai>
Multica-Task: TML-815 Multica-Run: 8d4be96f-1670-4bcc-9c1d-ab8c17a5ba25 Co-authored-by: multica-agent <github@multica.ai>
Co-authored-by: multica-agent <github@multica.ai>
SeasonsChange422
marked this pull request as ready for review
September 4, 2026 13:41
Co-authored-by: multica-agent <github@multica.ai>
5 tasks
Co-authored-by: multica-agent <github@multica.ai>
PR 规范检查结果状态:通过 通过:
下一步:无需进一步操作。本评论不阻止合并;最终合并资格由原生 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
目标
修复启用轨道接管摄像机时的视口右键行为,并让用户明确了解机位操控被禁用的原因和解除方式。
变更范围
contextmenu;通过event.composedPath()识别 open ShadowRoot 内的视口事件,从视口开始的右键手势拖出后释放仍会被抑制。pointerup、pointercancel、contextmenu、失焦和新指针序列清理,5 分钟 TTL 仅处理丢失终止事件的异常指针流。pointerdown先完整清除旧 active、pending 与两类 timer,再仅按本次事件是否为视口内、非交互控件右键重新 arm,避免丢失终止事件的旧手势污染下一次视口外独立右键。main的治理 bootstrap 合并提交665ba51ad5dc141f95e7073873c8e6532229ec11;本 PR 相对main不包含治理文件。验收标准
pointerdown后,新视口外真实右键在 Chromium、Firefox、WebKit 均会放行。main的 diff 仅含 10 个已复核产品/测试文件;产品树与复核 PASS 的fd2acbd0f37ffdd825ea6ad91019aa5a5f007e0c完全一致。测试结果
python -m unittest discover -s .github/scripts -p "test_*.py":5/5 通过。npm test:通过。npm run build:通过。npx vitest run packages/studio/test/camera-drive-routing.test.tsx:47/47 通过。npx playwright test e2e/timeline.spec.ts --project=chromium --project=firefox --project=webkit -g "real right-drag|ShadowRoot viewport|long-held|orphaned viewport":12/12 通过。npm run typecheck -w @lumora/studio:通过。npx eslint . --ignore-pattern e2e/_review-a11y-temp.spec.ts:0 error,4 条既有 Fast Refresh warning;未跟踪的审查临时文件不属于本 PR。git diff --check:通过。dec0e2a096c04894856662713f434ee9e0f57a0c:ci与git-governance均通过。风险和回滚
风险集中在跨 ShadowRoot 的窗口级右键事件顺序、导出运行态提示及 E2E 稳定帧等待。仓库治理 bootstrap 已通过独立 PR #17 合入
main,当前分支通过双亲合并提交同步该可信基线,不修改或绕过 Ruleset。若出现回归,可整体 revert 本 PR 的 squash merge commit;不会涉及数据迁移或持久化格式变更。