docs: align score type - #2498
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Timefold Solver Service documentation to consistently use the correct score type across examples and to clarify how demo data generators should wrap inputs when building requests.
Changes:
- Align constraint weight override examples to use
HardSoftScoreinstead ofHardMediumSoftScore. - Add an introductory sentence explaining that demo data generator methods should construct a
ModelRequestto wrap the input.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/src/modules/ROOT/pages/running-timefold-solver/service/demo-data.adoc | Adds a brief introductory instruction for implementing generator methods using ModelRequest. |
| docs/src/modules/ROOT/pages/running-timefold-solver/service/constraint-overrides.adoc | Updates Java/Kotlin examples to consistently use HardSoftScore in constraint weight overrides. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
triceo
requested changes
Jul 15, 2026
triceo
left a comment
triceo
left a comment
Collaborator
There was a problem hiding this comment.
As things stand now, I think this is not wise.
triceo
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix lingering remarks from #2479