docs: change constraint-overrides to module configuration overrides - #2501
Merged
Conversation
TomCools
had a problem deploying
to
documentation (preview)
July 15, 2026 10:11 — with 
GitHub Actions
Failure
GitHub Actions
Failure
TomCools
had a problem deploying
to
documentation (preview)
July 15, 2026 10:12 — with
GitHub Actions
Failure
GitHub Actions
Failure
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the Service documentation to generalize “constraint weight overrides” into broader “model configuration overrides”, including both per-constraint weights and per-constraint parameters, aligning with the request-scoped ModelConfigOverrides/@ConstraintReference mechanism.
Changes:
- Added a new Service doc page describing
ModelConfigOverrides,@ConstraintReference(weight + parameter modes), and how to apply overrides inModelConvertor. - Removed the old “Adjusting constraint weights” Service page and replaced the navigation entry to point at the new page.
- Kept legacy routing intent via
:page-aliases:(but requires an additional alias to preserve existing xrefs).
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| docs/src/modules/ROOT/pages/running-timefold-solver/service/model-config-overrides.adoc | New consolidated documentation for per-request model configuration overrides (weights + parameters). |
| docs/src/modules/ROOT/pages/running-timefold-solver/service/constraint-overrides.adoc | Removed legacy constraint-weight-only page in favor of the consolidated replacement. |
| docs/src/modules/ROOT/nav.adoc | Updates Service navigation to link to the new consolidated page. |
rsynek
reviewed
Jul 16, 2026
rsynek
left a comment
rsynek
left a comment
Contributor
There was a problem hiding this comment.
Looks very good. Let me know what you think about the global parameters.
rsynek
reviewed
Jul 16, 2026
rsynek
approved these changes
Jul 17, 2026
Contributor
|
@TomCools please check the outstanding Copilot comments. Otherwise looks good, thanks! |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+214
to
+225
| private static ConstraintParameters | ||
| getConstraintParameters(ModelConfig<MyPlanConfigOverrides> modelConfig) { | ||
|
|
||
| if (modelConfig.overrides() == null) { | ||
| return null; | ||
| } | ||
| MyPlanConfigOverrides overrides = modelConfig.overrides(); | ||
| return new ConstraintParameters( | ||
| overrides.getBufferBeforeShiftEnd(), | ||
| overrides.getMinimumPriorityLevel() | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Solves #2347
@rsynek , since this is Service heavy, might need your eyes on this.