capture: use length prefixed encoding to reliably receive events #695
+56
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petrosagg
commented
Aug 14, 2025
| /// | ||
| /// worker.dataflow::<u64,_,_>(|scope1| | ||
| /// std::thread::scope(move |s| { | ||
| /// s.spawn(move || timely::example(move |scope1| { |
Contributor
Author
There was a problem hiding this comment.
I moved the two sides in separate threads since if one operator blocks while writing to the socket nothing will unblock it
petrosagg
force-pushed
the
deflake-capture
branch
from
1941376 to
60d3b14
Compare
The existing capture/replay mechamism would produce a concatenation of bincode encoded messages. However, on the receiving end the bincode format does not have enough information for messages to be decoded accurately from a non-delimited stream, which could lead to the receiving end getting confused. This PR fixes the issue by prefixing each messages with its length in bytes. Signed-off-by: Petros Angelatos <petrosagg@gmail.com>
petrosagg
force-pushed
the
deflake-capture
branch
from
60d3b14 to
73108ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing capture/replay mechamism would produce a concatenation of bincode encoded messages. However, on the receiving end the bincode format does not have enough information for messages to be decoded accurately from a non-delimited stream, which could lead to the receiving end getting confused.
This PR fixes the issue by prefixing each messages with its length in bytes.