Return lifetimes to Scope and friends#785
Merged
frankmcsherry merged 7 commits intoTimelyDataflow:masterfrom Apr 11, 2026
Merged
Return lifetimes to Scope and friends#785frankmcsherry merged 7 commits intoTimelyDataflow:masterfrom
Scope and friends#785frankmcsherry merged 7 commits intoTimelyDataflow:masterfrom
Conversation
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Experimentation with removing lifetimes from
Scopewere not a success. The lack of static checks meant that un-diligent implementors (Claude, and folks who use it, like me) write code that they believe is correct, but is not because we were using diligence is place of static checks. This PR returns lifetimes explicitly, rather than nestled behind aScopetrait that hid the dependence. The lifetime now exists inStream,OperatorBuilder, and a few other places. These types are all lifetime'd, and shall not outlive the closure that constructs them (an HRTB on lifetimes is meant to prevent this, but who knows whatasyncis permitted to do these days).