Implement Copy for Scope#787
Merged
frankmcsherry merged 9 commits intoTimelyDataflow:masterfrom Apr 13, 2026
Merged
Conversation
16aada2 to
b99c939
Compare
b99c939 to
549a2af
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
Scopetype is roughly equivalent to two references toRefCellcontaining types, and doesn't require&mut selfreferences to function. This PR leans in to that and makes all access through&self, removing traits that say otherwise, and generally streamlining the type. Ultimately, we end up withScope<'s, T>: Copy.