Skip to content

v1.4.10-beta22

Pre-release
Pre-release

Choose a tag to compare

@github-actions github-actions released this 24 May 07:43
· 20 commits to main since this release

TankWatch

v1.4.10-beta22 (2026-05-24)

Full Changelog Previous Releases

  • beta22: single HARMFUL truthy check for addedAuras (simpler + DF exact pattern)
    beta21's two-step HELPFUL/HARMFUL cascade with pcall was leaking buffs
    into the harmful cache AND rejecting real harmful auras in combat when
    the C function returned secret boolean values. The conditional branch
    structure (if not filteredHelpful then reject else test harmful) had
    subtle truthy/secret evaluation bugs.
    User confirmed via /tankw renderdebug:
    - OOC: found=1-2 auras correctly cached + rendered (buttons visible)
    - IN COMBAT: found=0 despite GetAuraDataByIndex showing 3 auras
    Switched to single HARMFUL truthy check, no pcall — exactly DF's
    pattern (Features/Auras.lua:1632):
    if _IsAuraFilteredOut
    and not _IsAuraFilteredOut(unit, instId, 'HARMFUL') then
    cacheAdd(entry, aura, instId)
    end
    Buffs are naturally rejected: HELPFUL aura passed to HARMFUL filter
    returns true (filtered out), so 'not filteredOut' is falsy → skip.
    Only real harmful auras pass through.
    In-combat retest confirmed: cache now contains both readable and
    secret-tagged auras, found=2, both buttons render correctly.