Add System light/dark theme selection and Pale Graphite theme - #222
Merged
Conversation
Support selecting separate light/dark themes when "System" theme is active. Add SystemLightTheme and SystemDarkTheme to user settings and update theme application logic. Introduce new "LightGray" (Pale Graphite) theme. Refactor Settings UI with new ComboBox style and conditional visibility for system theme options. Update localization and view model for new theme options.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds finer-grained theming by allowing separate light/dark theme choices when “System” is selected, and introduces a new light theme (“Pale Graphite” / LightGray). The update also refactors Settings UI styling to use a dedicated ComboBox style and updates theme application logic and localization resources.
Changes:
- Add
SystemLightTheme/SystemDarkThemesettings and update theme resolution whenThemeType.Systemis active. - Introduce new
ThemeType.LightGray(“Pale Graphite”) and include it in theme selection and theme-cycling logic. - Refactor Settings UI theme section (conditional light/dark theme pickers when System theme is selected) and add a shared Settings ComboBox style.
Reviewed changes
Copilot reviewed 10 out of 10 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| GetMyIP/Views/SettingsPage.xaml | Adds conditional light/dark theme selectors for System mode and switches to a dedicated Settings ComboBox style. |
| GetMyIP/ViewModels/SettingsViewModel.cs | Provides curated theme lists (ThemeTypes, SystemThemeTypes) for Settings UI. |
| GetMyIP/ViewModels/NavigationViewModel.cs | Updates keyboard theme-cycling to include LightGray. |
| GetMyIP/Styles/ComboBoxStyle.xaml | Introduces SettingsComboBox style based on MaterialDesign ComboBox. |
| GetMyIP/Models/Enums.cs | Adds ThemeType.LightGray with localized description key. |
| GetMyIP/Languages/Strings.en-US.xaml | Adds new strings for Light/Dark mode theme labels and the “Pale Graphite” theme name. |
| GetMyIP/Helpers/MainWindowHelpers.cs | Applies SystemLightTheme/SystemDarkTheme selection logic and defines LightGray theme colors. |
| GetMyIP/Converters/EnumToVisibilityConverter.cs | Adds enum-to-Visibility converter for conditional UI display. |
| GetMyIP/Configuration/UserSettings.cs | Adds persisted settings for system light/dark theme selection. |
| GetMyIP/App.xaml | Merges the new ComboBox style resource dictionary. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add System light/dark theme selection and Pale Graphite theme
Support selecting separate light/dark themes when "System" theme is active. Add SystemLightTheme and SystemDarkTheme to user settings and update theme application logic. Introduce new "LightGray" (Pale Graphite) theme. Refactor Settings UI with new ComboBox style and conditional visibility for system theme options. Update localization and view model for new theme options.