Remove Vanara; improve clipboard handling and feedback - #225
Merged
Conversation
Replaced Vanara clipboard code with WPF Clipboard API and retry logic. Added localized message and UI feedback for clipboard failures. Updated Readme to remove Vanara dependency.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR removes the Vanara-based clipboard implementation and shifts clipboard operations to the WPF Clipboard API, adding retry handling and user-facing failure messaging, plus updating documentation/dependencies accordingly.
Changes:
- Replaced Vanara clipboard interop with WPF
Clipboard.SetTextplus retry logic. - Added a localized snackbar message for clipboard failures in the main “Copy to clipboard” command path.
- Removed the Vanara NuGet/package documentation references.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| GetMyIP/ViewModels/NavigationViewModel.cs | Adds snackbar feedback when the main copy-to-clipboard command fails. |
| GetMyIP/Helpers/ClipboardHelper.cs | Replaces Vanara P/Invoke clipboard code with WPF Clipboard API + retry loop. |
| GetMyIP/Languages/Strings.en-US.xaml | Adds a new localized string for clipboard failure feedback. |
| GetMyIP/GetMyIP.csproj | Removes the Vanara package reference. |
| GetMyIP/Readme.txt | Removes Vanara from the documented dependency list. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
187
to
191
| else | ||
| { | ||
| _log.Error("CopyToClipboard failed."); | ||
| SnackBarMsg.ClearAndQueueMessage(GetStringResource("MsgText_CopyToClipboardFail")); | ||
| } |
Contributor
There was a problem hiding this comment.
Fixed in commit Add clipboard failure feedback to RightMouseUp in NavigationViewModel. Added an else clause to RightMouseUp that logs the failure and shows the MsgText_CopyToClipboardFail snackbar, matching the pattern used in CopyToClipboard().
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaced Vanara clipboard code with WPF Clipboard API and retry logic. Added localized message and UI feedback for clipboard failures. Updated Readme to remove Vanara dependency.