Standardization of Inno Setup localization files. - #238
Merged
Conversation
Standardize layout and format of the localization file to be consistent with other TImthreetwelve apps. Additionally added missing RegDeleteValue in Uninstall procedure. Cleaned up code section.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR standardizes the Inno Setup localization file structure/format to match the author’s conventions across other Timthreetwelve apps, and it cleans up parts of the Inno Setup script including uninstall cleanup logic.
Changes:
- Reordered and reformatted
GetMyIP.localization.isswith a consistent section layout and grouping. - Refactored portions of the
[Code]section inGetMyIP.iss(formatting/structure) and extended uninstall cleanup.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| GetMyIP/Inno_Setup/GetMyIP.localization.iss | Reformats and standardizes localization file layout; keeps per-language message blocks and ordering. |
| GetMyIP/Inno_Setup/GetMyIP.iss | Cleans up script code formatting and modifies uninstall behavior (settings/file cleanup + registry cleanup). |
Comments suppressed due to low confidence (5)
GetMyIP/Inno_Setup/GetMyIP.iss:235
CustomMessage('ClearSettings')does not exist in the localization file (it defines*.DeleteConfigFiles), so this will fail at runtime/compile depending on usage. Also theMsgBox(...)call is missing a trailing semicolon.
GetMyIP/Inno_Setup/GetMyIP.iss:240RegDeleteValueis missing a trailing semicolon, and it deletes the valueTimVerwhich doesn't appear to be used by this app. The app’s startup entry name appears to beGetMyIP(see SettingsViewModel), so uninstall cleanup should delete that value instead.
GetMyIP/Inno_Setup/GetMyIP.localization.iss:51- These strings have inconsistent capitalization in the sentence “It is recommended …” (
It Is recommended). This shows up in user-facing installer text.
GetMyIP/Inno_Setup/GetMyIP.localization.iss:60 - Typo in the Catalan translation:
RadMeshould beReadMe. This is user-visible.
GetMyIP/Inno_Setup/GetMyIP.localization.iss:66 - German translation typo:
vorhandenede.looks like an accidental extrade.and will read incorrectly to users.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardization of Inno Setup localization files. Closes #236
Standardize layout and format of the localization file to be consistent with other TImthreetwelve apps.
Additionally added missing RegDeleteValue in Uninstall procedure. Cleaned up code section.
Renamed both files.