Fix additional items identified by Copilot - #239
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Inno Setup installer scripts and localized installer text, addressing additional issues found in prior Copilot review—primarily around uninstall messaging/cleanup and translation text correctness.
Changes:
- Fix Catalan “ReadMe” typo in the custom message text.
- Update uninstall confirmation to use the existing
DeleteConfigFileslocalized message key. - Adjust uninstall registry cleanup to remove the correct Run entry name.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| GetMyIP/Inno_Setup/GetMyIP.localization.iss | Fixes a localized ReadMe label and modifies German welcome text. |
| GetMyIP/Inno_Setup/GetMyIP.iss | Updates uninstall prompt key usage and Run-registry cleanup behavior. |
| de.AppIsRunning=ausgeführt wird, schließen Sie es bitte, um mit der Installation fortzufahren. | ||
| de.DeleteConfigFiles=Möchten Sie die Einstellungen und Ausschlussdateien entfernen?%n%nWählen Sie 'Nein', wenn Sie eine Neuinstallation planen. | ||
| de.NotSelfContained=Dadurch wird die Standardversion von %1 Version %2 installiert.%n%nDiese Version erfordert eine vorhandenede. Installation von .NET 10 Desktop Runtime und ist sowohl mit x64- als auch mit x86-Systemen kompatibel.%n%nEs wird empfohlen, dass Sie alle anderen Anwendungen schließen, bevor Sie fortfahren.%n%nKlicken Sie auf "Weiter", um fortzufahren, oder auf "Abbrechen", um das Setup zu beenden. | ||
| de.NotSelfContained=Dadurch wird die Standardversion %1 Version %2 installiert.%n%nDiese Version erfordert eine bestehende Installation der .NET 10 Desktop Runtime und ist sowohl mit x64- als auch mit x86-Systemen kompatibel. |
… registry strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix additional items identified by Copilot