Refactor AppInfo: remove metadata, add Architecture#131
Merged
Conversation
Simplifies AppInfo by removing unused assembly/process metadata properties and introducing an Architecture property for process architecture. MainWindowHelpers now logs the app architecture at startup.
Contributor
There was a problem hiding this comment.
Pull request overview
This PR simplifies the AppInfo helper by removing unused application/assembly/process metadata accessors and adds a new Architecture property exposing the current process architecture. It also extends startup logging to record the architecture at launch, improving diagnostics in logs.
Changes:
- Removed multiple unused
AppInfometadata properties (assembly version strings, exe/name metadata, process module/start time, etc.). - Added
AppInfo.Architecturebased onRuntimeInformation.ProcessArchitecture. - Logged app/process architecture during startup in
MainWindowHelpers.LogStartup().
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| TimVer/Helpers/MainWindowHelpers.cs | Adds a startup log line for the app/process architecture. |
| TimVer/Helpers/AppInfo.cs | Removes unused metadata properties and introduces Architecture for process architecture reporting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Simplifies AppInfo by removing unused assembly/process metadata properties and introducing an Architecture property for process architecture.
MainWindowHelpers now logs the app architecture at startup.