Enhance code robustness and maintainability by standardizing string and null checks. - #157
Merged
Conversation
- Removed unused xmlns:local and SpacingConverter from AboutPage.xaml - Moved translations Expander from Grid.Row 12 to 11 for better layout - Made ThemeTypes in SettingsViewModel.cs get-only for immutability - Simplified PathHelpers.FindOnPath call in TextFileViewer.cs - Updated log message formatting in TextFileViewer.cs for consistency No related issues or pull requests.
- Refactored null and empty string checks for improved safety and clarity: - Removed unnecessary null-forgiving operator from `HistoryHelpers` when accessing `HistoryList.Count`. - Updated `PathHelpers` to use `.Length == 0` instead of `Path.GetExtension(filename) == string.Empty`. - Changed `ERROR_NO_ASSOCIATION` in `TextFileViewer` to a `const int` for consistency. - Replaced `fileName == string.Empty` with `.Length == 0` in `NavigationViewModel` for better null safety. - These changes enhance code robustness and maintainability by standardizing string and null checks. No related issues or pull requests.
Timthreetwelve
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HistoryHelperswhen accessingHistoryList.Count.PathHelpersto use.Length == 0instead ofPath.GetExtension(filename) == string.Empty.ERROR_NO_ASSOCIATIONinTextFileViewerto aconst intfor consistency.fileName == string.Emptywith.Length == 0inNavigationViewModelfor better null safety.No related issues or pull requests.