feat: add helm chart and docker compose for hybrid executors#4084
Merged
feat: add helm chart and docker compose for hybrid executors#4084
Conversation
eakmanrq
force-pushed
the
eakmanrq/add_helm_and_docker_compose_hybrid
branch
from
aecba3f to
f974395
Compare
sungchun12
suggested changes
Apr 4, 2025
docs/cloud/features/scheduler/scheduler/hybrid-executors/values.yaml
Outdated
Show resolved
Hide resolved
eakmanrq
force-pushed
the
eakmanrq/add_helm_and_docker_compose_hybrid
branch
3 times, most recently
from
fc161b5 to
688434c
Compare
eakmanrq
commented
Apr 9, 2025
sungchun12
suggested changes
Apr 9, 2025
docs/cloud/features/scheduler/hybrid_executors_docker_compose.md
Outdated
Show resolved
Hide resolved
docs/cloud/features/scheduler/hybrid_executors_docker_compose.md
Outdated
Show resolved
Hide resolved
eakmanrq
force-pushed
the
eakmanrq/add_helm_and_docker_compose_hybrid
branch
2 times, most recently
from
0617932 to
badd74b
Compare
sungchun12
approved these changes
Apr 9, 2025
Contributor
sungchun12
left a comment
sungchun12
left a comment
There was a problem hiding this comment.
I'm good. @treysp any opinions on ordering of information and the navbar?
treysp
reviewed
Apr 11, 2025
| ``` | ||
|
|
||
| Check for exit code 0 using `echo $?` to confirm the executors are healthy. | ||
| Example successful output: |
Contributor
There was a problem hiding this comment.
If I run the check command and see output like below, do I still need to run echo $? to check the exit code?
Collaborator
Author
There was a problem hiding this comment.
If the log looks like what is provided then it is unlikely that the exit code isn't 0, but there is still a chance. Therefore it would probably be best to make sure.
treysp
force-pushed
the
eakmanrq/add_helm_and_docker_compose_hybrid
branch
from
7cca1ff to
33c6e12
Compare
treysp
reviewed
Apr 14, 2025
| docker compose exec run-executor /app/pex executor run --check | ||
| ``` | ||
|
|
||
| Check for exit code 0 using `echo $?` to confirm the executors are healthy. |
Contributor
There was a problem hiding this comment.
Suggested change
| Check for exit code 0 using `echo $?` to confirm the executors are healthy. |
treysp
reviewed
Apr 14, 2025
| 2025-04-09 21:24:49,873 - MainThread - httpx - INFO - HTTP Request: GET https://cloud.tobikodata.com/sqlmesh/<YOUR ORG>/<YOUR PROJECT>/api/state-sync/enterprise-version/upgrade "HTTP/1.1 200 OK" (_client.py:1025) | ||
| 2025-04-09 21:24:49,889 - MainThread - tobikodata.tcloud.installer - INFO - Executor is installed (installer.py:180) | ||
| ``` | ||
|
|
Contributor
There was a problem hiding this comment.
Suggested change
| In addition, ensure the executors are healthy by running `echo $?` to confirm the check command returned exit code 0. |
treysp
approved these changes
Apr 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Documents how to deploy hybrid executors using either Helm or docker-compose