chore(todos): TODO 归位清理 + skip 抽查 - #1511
Merged
Merged
Conversation
📝 WalkthroughWalkthroughThe PR adds ChangesTODO tracking and documentation
Estimated code review effort: 1 (Trivial) | ~5 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✨ Finishing Touches 💡 1📝 Generate docstrings 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 2
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
PROGRESS.md (1)
31-34: 📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win记录完整的验证范围和必需命令。
Line 32 只记录
go test ./internal/adapters/ -short。Edge Server 应记录完整的go test ./... -short -count=1；Line 33 不应写为57 + 124 + 后续全量。同时补上git diff --check和git status --short --branch的执行结果。🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@PROGRESS.md` around lines 31 - 34, Update the “验证” section in PROGRESS.md to record the complete Edge Server command `go test ./... -short -count=1` and its result instead of the narrower adapter test. Replace the ambiguous “57 + 124 + 后续全量” description with the actual app/shared Vitest scope and result, and add execution results for `git diff --check` and `git status --short --branch`.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@PROGRESS.md`:
- Around line 15-16: Correct the classification in the PROGRESS.md summary: move
orchestrator_extract_preflight_test.go:102 from the short-mode gate category
into the missing-tool category because it lacks goimports, or rename the
category and update its count so the label and listed reason agree.
- Around line 7-13: Reconcile the TODO accounting in PROGRESS.md by explicitly
stating the denominator and how reference-only entries are classified. Correct
the category counts and location totals, clarify whether
prismRegistry.test.ts:13 is excluded, and add a formula whose categories and
removals sum to the claimed 30 remaining TODOs.
---
Outside diff comments:
In `@PROGRESS.md`:
- Around line 31-34: Update the “验证” section in PROGRESS.md to record the
complete Edge Server command `go test ./... -short -count=1` and its result
instead of the narrower adapter test. Replace the ambiguous “57 + 124 + 后续全量”
description with the actual app/shared Vitest scope and result, and add
execution results for `git diff --check` and `git status --short --branch`.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: d38629a9-7ebc-416d-881c-4e9fb70875ec
📒 Files selected for processing (22)
PROGRESS.mdapp/shared/src/chatview/components/RowItem.tsxapp/shared/src/chatview/i18n/resources.tsapp/shared/src/styles/tokens-base.cssapp/shared/src/transcript/normalizeHubMessages.tsapp/shared/src/transcript/pinMap.tsapp/shared/src/ui/DiffReviewPanelHelpers.tsapp/shared/src/ui/DiffReviewPanelTypes.tsapp/shared/src/ui/Markdown.tsxapp/shared/src/ui/Tooltip.test.tsxapp/shared/src/ui/diffWordTokens.tsapp/shared/src/ui/prismRegistry.test.tsapp/shared/src/workbench/ConversationSidebar.tsxapp/shared/src/workbench/pages/contacts/ContactMainParts.tsxapp/shared/src/workbench/pages/tasks/TaskMainViews.tsxapp/shared/src/workbench/workbenchTranscriptChromeActionMappers.tsapp/shared/src/workbench/workbenchTranscriptChromeLabels.tsedge-server/internal/adapters/acp.goedge-server/internal/adapters/acp_client.goedge-server/internal/adapters/claude_acp.goedge-server/internal/adapters/codex_acp.goedge-server/internal/adapters/opencode_acp.go
Comment on lines
+7
to
+13
| ## TODO 处理统计（39 处） | ||
| - 过时删除（a 类）8 处：pinMap 落地（pinMap.ts:1 / normalizeHubMessages.ts:51,73 / mappers.ts:510）、P6 Step3 闭环（DiffReviewPanelHelpers.ts:64 / DiffReviewPanelTypes.ts:39）、unpinMenu 已实现（resources.ts:277,783） | ||
| - ACP 补 #1404（b 类）12 处：acp.go:153、acp_client.go:35,251,266,296,312,332,357,366、claude_acp.go:123、codex_acp.go:133、opencode_acp.go:130（#1404 OPEN，ACP spike 增量采纳） | ||
| - 建 issue 并补号（c 类）12 处 → 8 个 issue：a11y 审批卡播报 #1503（RowItem:394）、copyLink #1504（mappers:110/labels:133）、word-diff 阈值 #1505（diffWordTokens:51）、Markdown 锚点 #1506（Markdown:96）、Tooltip 真机验证 #1507（Tooltip.test:191-195 ×3）、会话操作 #1508（ConversationSidebar:229）、HC 玻璃面板 #1509（tokens-base.css:586 + prismRegistry.test:13 引用）、数据层分页 #1510（ContactMainParts:70/TaskMainViews:110） | ||
| - 纯信息保留（d 类）："See ReadTextFile for the TODO" 等引用注释 ×5、claude_code.go:10 引用 —— 指向已带号主 TODO | ||
| - 剩余 30 处 TODO 全部带 issue 号（#1404/#1503-#1510），可追踪性 100% | ||
|
|
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Reconcile the TODO counts before merging.
Line 7 reports 39 TODOs. After 8 deletions, 31 entries remain. Lines 9-10 account for 24 TODOs, while Line 11 lists informational references without explaining the claimed 30 remaining TODOs. Line 10 also contains 13 location mentions unless prismRegistry.test.ts:13 is reference-only.
State the denominator and any reclassification rule. Add a formula that accounts for all entries and sums to 30.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@PROGRESS.md` around lines 7 - 13, Reconcile the TODO accounting in
PROGRESS.md by explicitly stating the denominator and how reference-only entries
are classified. Correct the category counts and location totals, clarify whether
prismRegistry.test.ts:13 is excluded, and add a formula whose categories and
removals sum to the claimed 30 remaining TODOs.
Comment on lines
+15
to
+16
| ### go（25 处） | ||
| - short mode 门 ×9：claude_adapter_integration_test.go:18、opencode_adapter_integration_test.go:17、hub_e2e_test.go:203,293,459,503、hub_integration_test.go:317,446、orchestrator_extract_preflight_test.go:102 中 goimports 未装 —— message 均说明原因 |
There was a problem hiding this comment.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Correct the skip-category classification.
Line 16 labels orchestrator_extract_preflight_test.go:102 as a short-mode gate, but the note says that goimports is missing. Move this entry to a tool-missing category, or change the category label and adjust the count.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@PROGRESS.md` around lines 15 - 16, Correct the classification in the
PROGRESS.md summary: move orchestrator_extract_preflight_test.go:102 from the
short-mode gate category into the missing-tool category because it lacks
goimports, or rename the category and update its count so the label and listed
reason agree.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
任务书 J：TODO 清理 + skip 抽查
TODO 归位（39 处 → 30 处，剩余全部带 issue 号）
新建 issue（标题带 TODO 标签）
skip 抽查（40 处：go 25 + app 15）——全部环境门，合理保留，无上报
验证
Summary by CodeRabbit
Documentation
Tests