chore(scripts): 消融一个自闭环的 Windows-path 死簇——删掉 6 个仓库内不可达的 smoke/release 脚本(−3,080 行,互相引用成闭环、用反斜杠路径互调、其中一处调用早已不存在的 .ps1),并修好 3 个活脚本在 Linux 上必然失败的路径(smoke matrix 的 tauri-dry 行改为真跑 verify-tauri-package-dry.py,实测 PASS) - #2281
Merged
Conversation
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DeliciousBuding
enabled auto-merge (squash)
September 3, 2026 09:22
DeliciousBuding
force-pushed
the
chore/scripts-estate-slim
branch
from
September 3, 2026 09:39
937d8be to
38e84c5
Compare
…本(共 3,080 行) Co-authored-by: Cursor <cursor@vectorcontrol.tech>
…verify-tauri-package-dry.py,另两处 release verifier 的 Windows 反斜杠路径字面量转正 Co-authored-by: Cursor <cursor@vectorcontrol.tech>
DeliciousBuding
force-pushed
the
chore/scripts-estate-slim
branch
from
September 3, 2026 09:48
38e84c5 to
1f54640
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 做什么
scripts/资产消融:删掉 6 个在仓库内完全不可达的脚本(−3,080 行),并修好 3 个活脚本里在 Linux 上必然失败的路径。净+7 / −3,090。1. 一个自闭环的 Windows-path 死簇
三条独立证据说明它们不可达:
入站引用是个闭环。 在 master 树上对 4 个非零命中的成员逐个
git grep -lF,引用者集合完全落在簇内:verify-localhost-product-loop.pyverify-local-stack-e2e-readiness.py、自己verify-local-stack-e2e-readiness.pyverify-localhost-observed-loop.py、自己verify-observed-localhost-dispatch.pyverify-local-stack-e2e-readiness.py、verify-localhost-observed-loop.py、自己verify-localhost-real-services.py簇根
verify-localhost-observed-loop.py与verify-tauri-sidecar-binary-smoke.py删除前后在仓库内均 0 命中。.github/workflows/**、Makefile、docs/**(含docs/governance/verifier-map.md)、scripts/verify/**、docker-compose.yml、deployments/**、AGENTS.md、CHANGELOG.md全都没有引用它们。它们在 Ubuntu 上根本跑不起来。 簇内互调用的是 Windows 反斜杠路径字面量,例如
invoke_repo_script(ctx["repo_root"], "scripts\\smoke\\verify-localhost-real-services.py", ...)。本 PR 后grep -rn 'scripts\\\\' scripts/ | wc -l= 0。其中一处调用的文件早已不存在。
verify-localhost-observed-loop.py:771调用scripts\\smoke\\verify-observed-localhost-dispatch.ps1,而仓库里已经没有任何.ps1(docs/archives/README.md:22:「.ps1verifier 已统一迁为.py」)。2. 三个活脚本的坏路径(修,不删)
scripts/smoke/verify-e2e-smoke-matrix.py:326的desktop-tauri-dry-smoke行原本是powershell -NoProfile -ExecutionPolicy Bypass -File <repo>/scripts/release/verify-tauri-package-dry.ps1 ...——
scripts/release/下只有.py,.ps1不存在 ⇒ 这一行永远失败/永远被跳过。改为sys.executable <repo>/scripts/release/verify-tauri-package-dry.py ...,参数形状逐字核对过(-RepoRoot/-ArtifactsRoot/-SkipInstall/-SkipExecutableCompile与 dry 脚本的 argparse 完全一致)。顺带删掉因此失去消费者的pwsh/powershell探测(get_command_path仍被 corepack 使用),并把 docstring 里「release 侧 tauri dry 脚本不在本批迁移范围,仍走 pwsh 调用」这句已经不成立的话改成实况。scripts/release/verify-tauri-package-readiness.py:111:assert_file_exists("scripts\\release\\verify-tauri-package-dry.py", ...)→ POSIX 形式。同函数下一行的read_text("scripts/release/verify-tauri-package-dry.py")本来就用的是 POSIX 形式,即同一个文件在两行里被写成两种路径。scripts/release/verify-packaged-login-real-readiness.py:109-111:打印给操作者照抄的 3 条命令是python .\scripts\...,在 bash 下照抄即失败 → 改为python ./scripts/...。真实验证
删除后 6 个 basename 在分支树上
git grep全部 0 命中;verify-doc-ssot.py的 DOC-ORPHAN-SELFTEST(#2276 加的孤儿自测门禁)没有变红 ⇒ 这 6 个脚本确实不在任何清单里。lane 侧还端到端真跑过修好的那一行:
verify-e2e-smoke-matrix.py跳过其它行、只跑desktop-tauri-dry-smoke(go 交叉编译 + sidecar 准备,57s)→RUN/PASS、exit 0,行内 evidence 含PASS: ... dry categorized script exists (scripts/release/verify-tauri-package-dry.py)。刻意没做(留给后续,不在本 PR 扩大战果)
scripts/verify/verify-ci-gates.py有一批 assert 的提示文案仍写着.ps1(如:457message 是...verify-web-hub-boundary.ps1而 pattern 是.py)。scripts/verify/**是主机禁区,本 PR 不动。scripts/release/verify-tauri-installer-smoke.py里还有被assert_path归一化、功能不坏的app\\/edge-server\\字面量。hub-server/scripts/setup-tokendance-oidc.py:121有 Windows 风格 print。scripts/dev/的.sh/.py成对不是重复:dev-up.sh(955B) 调用dev-up.py(4592B),dev-down/dev-start/setup同构,shell 是薄包装、python 是实现;且dev-up.sh被AGENTS.md:138、docs/developer-quickstart.md:124、CONTRIBUTING.md:41、docker-compose.yml:8、verify-ci-gates.py:329引用。不动。