Skip to content

chore(scripts): 消融一个自闭环的 Windows-path 死簇——删掉 6 个仓库内不可达的 smoke/release 脚本(−3,080 行,互相引用成闭环、用反斜杠路径互调、其中一处调用早已不存在的 .ps1),并修好 3 个活脚本在 Linux 上必然失败的路径(smoke matrix 的 tauri-dry 行改为真跑 verify-tauri-package-dry.py,实测 PASS) - #2281

Merged
DeliciousBuding merged 2 commits into
masterfrom
chore/scripts-estate-slim
Sep 3, 2026

Conversation

@DeliciousBuding

Copy link
Copy Markdown
Collaborator

这个 PR 做什么

scripts/ 资产消融:删掉 6 个在仓库内完全不可达的脚本(−3,080 行),并修好 3 个活脚本里在 Linux 上必然失败的路径。净 +7 / −3,090

1. 一个自闭环的 Windows-path 死簇

803  scripts/smoke/verify-localhost-observed-loop.py
690  scripts/smoke/verify-localhost-product-loop.py
594  scripts/smoke/verify-local-stack-e2e-readiness.py
441  scripts/smoke/verify-observed-localhost-dispatch.py
389  scripts/smoke/verify-localhost-real-services.py
163  scripts/release/verify-tauri-sidecar-binary-smoke.py

三条独立证据说明它们不可达:

  1. 入站引用是个闭环。 在 master 树上对 4 个非零命中的成员逐个 git grep -lF,引用者集合完全落在簇内:

    文件 仓库内引用者
    verify-localhost-product-loop.py verify-local-stack-e2e-readiness.py、自己
    verify-local-stack-e2e-readiness.py verify-localhost-observed-loop.py、自己
    verify-observed-localhost-dispatch.py verify-local-stack-e2e-readiness.pyverify-localhost-observed-loop.py、自己
    verify-localhost-real-services.py 同上三个

    簇根 verify-localhost-observed-loop.pyverify-tauri-sidecar-binary-smoke.py 删除前后在仓库内均 0 命中.github/workflows/**Makefiledocs/**(含 docs/governance/verifier-map.md)、scripts/verify/**docker-compose.ymldeployments/**AGENTS.mdCHANGELOG.md 全都没有引用它们。

    唯一一处看似外部引用来自 .tmp/approved-real-demo-readiness/run-996980/redacted-manifest.json,而 .tmp/.gitignore:159git ls-files .tmp 返回 0 行 ⇒ 那是本机未跟踪的一次性产物,不是仓库引用。

  2. 它们在 Ubuntu 上根本跑不起来。 簇内互调用的是 Windows 反斜杠路径字面量,例如 invoke_repo_script(ctx["repo_root"], "scripts\\smoke\\verify-localhost-real-services.py", ...)。本 PR 后 grep -rn 'scripts\\\\' scripts/ | wc -l = 0

  3. 其中一处调用的文件早已不存在。 verify-localhost-observed-loop.py:771 调用 scripts\\smoke\\verify-observed-localhost-dispatch.ps1,而仓库里已经没有任何 .ps1docs/archives/README.md:22:「.ps1 verifier 已统一迁为 .py」)。

2. 三个活脚本的坏路径(修,不删)

  • scripts/smoke/verify-e2e-smoke-matrix.py:326desktop-tauri-dry-smoke 行原本是
    powershell -NoProfile -ExecutionPolicy Bypass -File <repo>/scripts/release/verify-tauri-package-dry.ps1 ...
    ——scripts/release/ 下只有 .py.ps1 不存在 ⇒ 这一行永远失败/永远被跳过。改为 sys.executable <repo>/scripts/release/verify-tauri-package-dry.py ...,参数形状逐字核对过(-RepoRoot / -ArtifactsRoot / -SkipInstall / -SkipExecutableCompile 与 dry 脚本的 argparse 完全一致)。顺带删掉因此失去消费者的 pwsh/powershell 探测(get_command_path 仍被 corepack 使用),并把 docstring 里「release 侧 tauri dry 脚本不在本批迁移范围,仍走 pwsh 调用」这句已经不成立的话改成实况。
  • scripts/release/verify-tauri-package-readiness.py:111assert_file_exists("scripts\\release\\verify-tauri-package-dry.py", ...) → POSIX 形式。同函数下一行的 read_text("scripts/release/verify-tauri-package-dry.py") 本来就用的是 POSIX 形式,即同一个文件在两行里被写成两种路径。
  • scripts/release/verify-packaged-login-real-readiness.py:109-111:打印给操作者照抄的 3 条命令是 python .\scripts\...,在 bash 下照抄即失败 → 改为 python ./scripts/...

真实验证

$ python3 scripts/verify/verify-doc-ssot.py     # doc SSOT ok(68 script paths / 99 AGENTS paths / 29 self-tests 全过)
$ python3 scripts/verify/verify-ci-gates.py     # rc=0
$ bash scripts/verify/verify-commit-messages.sh origin/master HEAD   # commit message check ok (2 commits)
$ git diff --check                              # 无空白错误
$ python3 -c "py_compile.compile(...)" 全部 scripts/**/*.py           # 全部编译通过
$ grep -rn 'scripts\\\\' scripts/ | wc -l        # 0
$ grep -n "powershell_path\|pwsh" scripts/smoke/verify-e2e-smoke-matrix.py   # 0(无残留死变量)

删除后 6 个 basename 在分支树上 git grep 全部 0 命中;verify-doc-ssot.pyDOC-ORPHAN-SELFTEST#2276 加的孤儿自测门禁)没有变红 ⇒ 这 6 个脚本确实不在任何清单里。

lane 侧还端到端真跑过修好的那一行:verify-e2e-smoke-matrix.py 跳过其它行、只跑 desktop-tauri-dry-smoke(go 交叉编译 + sidecar 准备,57s)→ RUN / PASS、exit 0,行内 evidence 含 PASS: ... dry categorized script exists (scripts/release/verify-tauri-package-dry.py)

刻意没做(留给后续,不在本 PR 扩大战果)

  • scripts/verify/verify-ci-gates.py 有一批 assert 的提示文案仍写着 .ps1(如 :457 message 是 ...verify-web-hub-boundary.ps1 而 pattern 是 .py)。scripts/verify/** 是主机禁区,本 PR 不动。
  • scripts/release/verify-tauri-installer-smoke.py 里还有被 assert_path 归一化、功能不坏的 app\\ / edge-server\\ 字面量。
  • hub-server/scripts/setup-tokendance-oidc.py:121 有 Windows 风格 print。
  • scripts/dev/.sh/.py 成对不是重复dev-up.sh(955B) 调用 dev-up.py(4592B),dev-down/dev-start/setup 同构,shell 是薄包装、python 是实现;且 dev-up.shAGENTS.md:138docs/developer-quickstart.md:124CONTRIBUTING.md:41docker-compose.yml:8verify-ci-gates.py:329 引用。不动。

@coderabbitai

coderabbitai Bot commented Sep 3, 2026

Copy link
Copy Markdown

Important

Review skipped

Auto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 75642e25-26bf-458c-a0a2-f374ca278800

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@DeliciousBuding
DeliciousBuding enabled auto-merge (squash) September 3, 2026 09:22
@DeliciousBuding
DeliciousBuding force-pushed the chore/scripts-estate-slim branch from 937d8be to 38e84c5 Compare September 3, 2026 09:39
DeliciousBuding and others added 2 commits September 3, 2026 17:48
…本(共 3,080 行)

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
…verify-tauri-package-dry.py,另两处 release verifier 的 Windows 反斜杠路径字面量转正

Co-authored-by: Cursor <cursor@vectorcontrol.tech>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant