chore(public-face): 公开面脱敏——测试夹具里的 operator 个人名/家目录 38 处改中性名、内部迭代编号 round-NN 8 处删除但保留 issue 与日期锚点、1 处畸形 Windows 路径夹具修正(16 文件净 0 行,历史暴露面已量化未清洗) - #2284
Merged
Conversation
Co-authored-by: Cursor <cursor@vectorcontrol.tech>
Co-authored-by: Cursor <cursor@vectorcontrol.tech>
Co-authored-by: Cursor <cursor@vectorcontrol.tech>
Co-authored-by: Cursor <cursor@vectorcontrol.tech>
Co-authored-by: Cursor <cursor@vectorcontrol.tech>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
做了什么
round-70「不值得公开的面」轴的脱敏批(下文用
U指代被替换掉的 operator 个人名,本 PR 刻意不再复写它):C:\Users\UC:\Users\Example(仓库既有中性名,双层\\转义保留)/home/u/.../home/example/...(与既有/Users/example一致)currentUserIdAlice/alice(authStateMachine、pipeline-integration 已有先例)round-NNC:\Users\file.tsC:\Users\Example\file.ts(同文件无等价 Windows 用例,修不删)16 files changed, 52 insertions(+), 52 deletions(-) —— 净 0 行,纯字面替换,无行为改动。
hub-server/internal/service/device/device.go是唯一非测试文件:改的是注释里的round-NN。为什么这些算「不该公开」
subagent_result_sanitize.go:25与用户名无关(已实测),生产代码 0 命中(git grep -n "U" -- ':!*_test.go' ':!*.test.ts*'rc=1)。也就是说这些字面量对断言的意义只是「一个 Windows/Unix 绝对路径」,换成中性名不损失任何覆盖。round-NN是内部迭代计数,对公开仓库的读者是不可解引用的噪声;issue 号才是可解引用锚点,所以留 issue 删编号。证据(主机独立复跑,不采信车道自述)
rebase 到
a15bf7dc(#2283 testkit shim 消融)后复跑:process_executor_test.go同时含pkg/testkitimport 与/home/example夹具,edge build + lifecycle/sdk 测试仍全绿。暗卷(变异测试,证明断言真的在管这些字面量):
TestSanitizeSubAgentResult_FilePath变红 ✅sdk_fixture_mapper_test.go走的是 sdk 包自己的sdkWindowsPathPattern,不经 lifecycle 正则;补做破坏sdkWindowsPathPattern→ SDK 脱敏断言真变红(replay 裸漏路径)✅历史暴露面(只量化,未清洗)
C:\Users\U:2 个提交(2026-08-14372a2119、2026-08-20f296ad02),仅在 4 个 edge-server 测试文件。U:6 个提交,最早 2026-08-14、最新 2026-08-253b2b527a,跨 8 个文件(4 Go + 4 前端测试)。git filter-repo、没有 force-push:历史重写不可逆且会打乱所有下游 clone,属 operator 决策项。合入本 PR 后,工作树 HEAD 已不含该字面量,但历史仍可检出。Negative constraints(刻意没做)
AGENTS.md、scripts/verify/**(其中 2 处round-NN是载荷性夹具——verifier 自己的测试用例,删了会让门禁失去被测目标)、.github/**、Makefile、api/openapi.yaml。已用git diff --name-only逐一确认。100.64.0.0/10(CGNAT 网段,不是个人信息)、bench 里的Kunpeng硬件注记(性能数据的必要上下文)、tailscale(产品功能名)、/root/.ssh/authorized_keys示例(文档必需路径)。(#2241 lane A)/(#2250 wave lane A)里的lane A属内部词但不是round-NN范围,本 PR 未动(列为后续候选)。