refactor(data-mode): drop redundant statusLabel and dead workbenchDataModeLabel helper - #2322
Merged
Merged
Conversation
…aModeLabel helper Co-authored-by: Cursor <cursor@vectorcontrol.tech>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hard-evidence subtraction on the WorkbenchDataModeContract policy table, per the read-only audit. Full-table ablation is a NEGATIVE experiment — the centralized policy SSOT is KEPT (all boolean fields are derivable from mode but are a real multi-consumer single policy source; abating would fragment policy across desktop/web/gate call sites). allowsMockData and allowsFixtureData are also KEPT (live consumers in shared/src/testing/e2eDataModeContract.ts E2E validator).
This PR removes only:
WorkbenchDataModeContract.statusLabel(=== mode for all 5 literals): interface field + 5 table entries; Desktop/Web model read.modeinstead (value/type identical).workbenchDataModeLabelhelper: definition, demo/index.ts re-export, test import/assertions. normalize-exact-input coverage preserved asnormalizeWorkbenchDataMode("auto"/"demo+edge"/"mock (auto fallback)") === "auto".Preserved unchanged: mode literal type, all remaining policy booleans, observed/approved-real semantics, normalization aliases, storage/override/env runtime behavior.
Net: 5 files +8/-24.
Verification: shared dataMode 5/5; desktop model 13/13; web model 40/40; shared/desktop/web typecheck PASS; git diff --check PASS; canonical coverage baseline shared (lines 90.26, uncovered 1) PASS, web (lines 70.13) PASS, desktop (lines 66.32) PASS, all zero-skipped/no-regression.