refactor(edge): process_executor residual pure slice continue (#835)#851
Conversation
Extract pure helpers from process_executor.go without changing ProcessExecutor control flow: - process_defaults.go (timeouts, concurrency, resolve helpers) - process_ids.go (sub-agent IDs/paths/thread/prompt prefix) - process_status.go (permission normalize, evidence final status, sub-agent msg/registry status) - process_payloads.go (bus/queue/item payload builders) - process_output_text.go (stderr log line split) process_executor.go 1342 → 1240 LOC. Add focused unit tests for the peeled pure helpers. Closes #835.
|
Warning Review limit reached
Next review available in: 51 minutes Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (7)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
…862) * refactor(edge): process_executor residual pure slice continue (#856) Peel remaining pure helpers from process_executor after #835/#851: newSubAgentInstance + aggregatorOutput, plus API-key-only hub stream sanitize at fireHubStream/collector sinks. No control-flow rewrite. Closes #856. * fix(edge): avoid secret-guard false positive in residual test (#856)
Summary
Continue pure residual extract from
process_executor.gointo lifecycle helper files (process_defaults,process_ids,process_output_text,process_payloads,process_status).No ProcessExecutor control-flow rewrite.
LOC: process_executor.go 1342 → ~1240
go test ./internal/lifecycle/green.Closes #835