Skip to content

Conversation

@Ramarti
Copy link
Collaborator

@Ramarti Ramarti commented Mar 5, 2021

No description provided.

AngelaKTE and others added 30 commits January 7, 2021 18:47
convert_etherscan_csv.py: fixed typo
model/config.py: fixed param
model/parts/system_policies.py: was using outdated path to data
Add state update functions used by data
randomshinichi and others added 28 commits February 26, 2021 15:46
… did not expect that it had to convert to a Decimal. Most likely 0x8b6 had an action that properly did Decimal conversion before p_join_pool() was triggered
…ut it still doesn't show up in the final JSON for some reason)
…group_1inch_aggregated_swaps()

Current situation: turn_events_into_actions() detects 1inch aggregate swaps and makes them into separate Action objects. However, these separate Action objects are still grouped together later in produce_actions() by txhash. This messes up classify_actions(). So the function that turned the dict (that classified Action groups by txhash) needs to be made more complex.

As new Defi startups figure out more ways to make trickier transactions, we might need to abandon the assumption of grouping by txhash.
- update NB1
- added plots
- cleaned up charts
- new name (stating the pool)
- all text final
- all links final
- all plots final

- ONLY MISSING is final check after update .json file
- sanity check w/ new .json file
- tiny fixes
Update NB1-PoolExploration-0x8b6-V1.0.ipynb
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@Ramarti Ramarti merged commit ee9156b into main Mar 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants