-
Notifications
You must be signed in to change notification settings - Fork 29
Release #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
convert_etherscan_csv.py: fixed typo model/config.py: fixed param model/parts/system_policies.py: was using outdated path to data
Add state update functions used by data
coingecko works
… did not expect that it had to convert to a Decimal. Most likely 0x8b6 had an action that properly did Decimal conversion before p_join_pool() was triggered
…ut it still doesn't show up in the final JSON for some reason)
…group_1inch_aggregated_swaps() Current situation: turn_events_into_actions() detects 1inch aggregate swaps and makes them into separate Action objects. However, these separate Action objects are still grouped together later in produce_actions() by txhash. This messes up classify_actions(). So the function that turned the dict (that classified Action groups by txhash) needs to be made more complex. As new Defi startups figure out more ways to make trickier transactions, we might need to abandon the assumption of grouping by txhash.
- update NB1 - added plots - cleaned up charts
1inch aggregate swap fix
- new name (stating the pool) - all text final - all links final - all plots final - ONLY MISSING is final check after update .json file
- sanity check w/ new .json file - tiny fixes
Update NB1-PoolExploration-0x8b6-V1.0.ipynb
|
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.