Skip to content

Fix: event parameters label truncation in action configuration panel - #17416

Merged
johnsoncherian merged 5 commits into
chore/release-3.20.216-ltsfrom
fix/event-params-label-truncation
Aug 25, 2026
Merged

Fix: event parameters label truncation in action configuration panel#17416
johnsoncherian merged 5 commits into
chore/release-3.20.216-ltsfrom
fix/event-params-label-truncation

Conversation

@vjaris42

@vjaris42 vjaris42 commented Aug 5, 2026

Copy link
Copy Markdown
Collaborator

📝 What this does

Fixes parameter labels (e.g. "targetBrand", "TargetYmlB") being truncated/hidden behind text inputs in the event action configuration panel by switching to a stacked layout matching the updated Figma design.

Closes

5091

🔀 Changes

  • Changed parameter fields from side-by-side col-3/col-9 grid to stacked layout (label on top, full-width input below)
  • Applied correct Figma token values: 12px font, 18px line-height, 2px gap between label and input, 12px gap between fields
  • Used tw-text-text-default for label color consistency

🧪 How to test

  • Add a button widget, configure an event with action "Run query"
  • Select a query that has parameters with long names
  • Verify parameter labels are fully visible above the inputs (not truncated)
  • Verify spacing matches the Figma design (compact, stacked layout)

@netlify

netlify Bot commented Aug 5, 2026

Copy link
Copy Markdown

Deploy Preview for storybook-tooljet failed.

Name Link
🔨 Latest commit 0571f67
🔍 Latest deploy log https://app.netlify.com/projects/storybook-tooljet/deploys/6a7aa7c20d89ee0008edc837

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the “Run JS parameters” action configuration UI to prevent long parameter names from being truncated by switching from a side-by-side grid layout to a stacked (label-above-input) layout aligned with the updated Figma design.

Changes:

  • Replaced the row/col-* layout with a vertical flex layout for parameters.
  • Applied Figma-aligned spacing (12px between fields, 2px between label and input) and typography (12px / 18px).
  • Standardized label styling using Tailwind token classes.

@Mekhla-Asopa Mekhla-Asopa added the create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile label Aug 7, 2026
@Mekhla-Asopa Mekhla-Asopa added create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile and removed create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Aug 7, 2026
@adishM98 adishM98 added create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile and removed create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Aug 7, 2026
@vjaris42 vjaris42 added create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile and removed create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Aug 7, 2026
@github-actions

github-actions Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

🚀 EE LTS Review App Deployed!

Resource Link
App URL https://tooljet-ee-lts-pr-17416.onrender.com
Render Dashboard https://dashboard.render.com/web/srv-d9qr1mp42hec73esegkg

Deployed using DockerHub-based pipeline - LTS Edition

@github-actions github-actions Bot added active-ee-lts-review-app For lts (github action build and deploy on render)) and removed create-ee-lts-review-app uses ./docker/LTS/ee/ee-preview.Dockerfile labels Aug 7, 2026
@adishM98 adishM98 added the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 8, 2026
@github-actions github-actions Bot removed the active-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 8, 2026
@Mekhla-Asopa Mekhla-Asopa removed the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 10, 2026
@github-actions github-actions Bot added the active-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 10, 2026
@adishM98 adishM98 added the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 10, 2026
@Mekhla-Asopa Mekhla-Asopa removed the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 10, 2026
@adishM98 adishM98 added the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 10, 2026
@Mekhla-Asopa Mekhla-Asopa removed the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔄 EE LTS Review App Rebuilding

New commit 0571f67 pushed. Image updated and deployment triggered.

Using cached layers for faster build

@Mekhla-Asopa Mekhla-Asopa added the run-cypress Cypress E2E action label Aug 11, 2026
@adishM98 adishM98 added the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 11, 2026
@github-actions github-actions Bot removed the active-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

Security Audit Report

Node module vulnerabilities summary (total across frontend, server, marketplace, plugins, root):
🔴 Critical: 0
🟠 High: 0
🟡 Moderate: 0

Critical packages:
None 🎉

ℹ️ Runs automatically on every PR update (also triggerable via the check-vulnerability label). Critical/High should be fixed before merge; Moderate can be tracked separately. Counts are from npm audit — per-workspace JSON artifacts are on the summary page.

@johnsoncherian
johnsoncherian changed the base branch from lts-3.16 to chore/release-3.20.216-lts August 25, 2026 11:08
@johnsoncherian
johnsoncherian merged commit c3914c3 into chore/release-3.20.216-lts Aug 25, 2026
200 of 208 checks passed
@johnsoncherian
johnsoncherian deleted the fix/event-params-label-truncation branch August 25, 2026 11:08
@github-actions github-actions Bot removed the suspend-ee-lts-review-app For lts (github action build and deploy on render)) label Aug 25, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

run-cypress Cypress E2E action tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants