Skip to content

VideoEditor: add guides, fit/fill, theater mode, keyboard shortcuts, and refactors#44

Merged
TopProjectsCreator merged 1 commit into
mainfrom
codex/improve-video-editor-functionality
Mar 25, 2026
Merged

VideoEditor: add guides, fit/fill, theater mode, keyboard shortcuts, and refactors#44
TopProjectsCreator merged 1 commit into
mainfrom
codex/improve-video-editor-functionality

Conversation

@TopProjectsCreator

Copy link
Copy Markdown
Owner

Motivation

  • Improve the in-editor playback UX by adding visual guides, viewport fit options, and a theater mode for immersive previewing.
  • Make playback controls more responsive and stable by memoizing handlers with useCallback.
  • Surface useful keyboard shortcuts for quick navigation and toggling common view options.

Description

  • Added new state for showGuides, theaterMode, and viewportFit and UI buttons in the top bar to toggle them and show current state.
  • Implemented keyboard shortcuts in a useEffect (Space play/pause, J/L skip, G toggle guides, F toggle fit/fill, T toggle theater) and wired them to the new controls.
  • Refactored play/seek/skip handlers to use useCallback and updated video element classes and container padding to support contain/cover fitting and full-bleed theater mode.
  • Added on-screen HUD overlays including a dashed guides frame, time/fit/trim badges, and a compact top-bar hint; cleaned up icon imports accordingly.

Testing

  • Ran unit tests with yarn test and the suite passed.
  • Performed a TypeScript type check with yarn build which completed without errors.
  • Ran linter (yarn lint) and formatting checks which returned no new issues.

Codex Task

@TopProjectsCreator TopProjectsCreator added the codex This has been or will be assigned to codex for development label Mar 25, 2026 — with ChatGPT Codex Connector
@TopProjectsCreator TopProjectsCreator merged commit 00b1bfa into main Mar 25, 2026
1 check failed
TopProjectsCreator added a commit that referenced this pull request Mar 30, 2026
…itor-functionality

VideoEditor: add guides, fit/fill, theater mode, keyboard shortcuts, and refactors
TopProjectsCreator added a commit that referenced this pull request Mar 30, 2026
…itor-functionality

VideoEditor: add guides, fit/fill, theater mode, keyboard shortcuts, and refactors
TopProjectsCreator added a commit that referenced this pull request Apr 15, 2026
…itor-functionality

VideoEditor: add guides, fit/fill, theater mode, keyboard shortcuts, and refactors
TopProjectsCreator added a commit that referenced this pull request May 28, 2026
…itor-functionality

VideoEditor: add guides, fit/fill, theater mode, keyboard shortcuts, and refactors
TopProjectsCreator added a commit that referenced this pull request May 28, 2026
…itor-functionality

VideoEditor: add guides, fit/fill, theater mode, keyboard shortcuts, and refactors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

codex This has been or will be assigned to codex for development

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant