Skip to content

Add --min-severity flag to control which findings appear in reports - #9

Merged
Topicspot merged 1 commit into
Topicspot:mainfrom
Sasireddy001:feat/add-min-severity
Jul 31, 2026
Merged

Add --min-severity flag to control which findings appear in reports#9
Topicspot merged 1 commit into
Topicspot:mainfrom
Sasireddy001:feat/add-min-severity

Conversation

@Sasireddy001

Copy link
Copy Markdown
Contributor

This PR closes #7.

It adds a --min-severity option to skillfrisk scan so you can filter findings down to a minimum severity:

  • low (default) — show everything
  • medium
  • high
  • critical

The filter applies to the terminal table, JSON, SARIF, and HTML outputs, and it also updates the exit code so the report and CI result stay consistent.

I added tests for the high and medium thresholds, invalid values, and the --no-fail-on-high interaction, and updated the README with an example.

@Sasireddy001

Copy link
Copy Markdown
Contributor Author

Hi! Just a friendly follow-up.

The implementation, tests, and documentation updates are complete. It looks like the remaining step is workflow approval for external contributors so CI can run.

Thank you for taking a look.

@Sasireddy001
Sasireddy001 force-pushed the feat/add-min-severity branch from 1d19387 to 9c8c0ae Compare July 30, 2026 03:57

@Topicspot Topicspot left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for picking this up, and for reading the codebase first. The filter lands in the right place, before any rendering, so the table, JSON, SARIF, HTML, the risk score and the exit code all tell the same story, which is exactly what #7 asked for. Reusing the --fail-on validation pattern from diff keeps the CLI consistent. I ran the branch through the full local gate (ruff, mypy, pytest, vulture) and everything passes. Fork CI needs a manual approval this setup cannot give, so I verified locally instead. Merging.

@Topicspot
Topicspot merged commit f49c226 into Topicspot:main Jul 31, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add --min-severity to filter the report

2 participants