fix(#310): firefox-gen was red since #297 β and "renders the atlas" passed on a DEAD atlas - #311
Merged
Merged
Conversation
β¦sed on a DEAD atlas main's firefox-gen 6/6 shard has failed on EVERY run since a8ee9b4 -- #297's merge, when the atlas became the default. Four runs, unnoticed, because PR CI is chromium-only and firefox/webkit run on push-to-main. Root cause is the environment, not the atlas. Probed with Playwright's firefox against the real page: webgl: false hudText: "Atlas β chatt error: The browser supports WebGL, but initialization failed." typeChip: false console: "Error constructing CesiumWidget. Visit http://get.webgl.org ..." Headless firefox has no WebGL, Cesium's Viewer ctor throws, AtlasViewer catches it into its error state, and everything behind `{ready && β¦}` -- chips, count, legend -- never renders. Real firefox has WebGL. The tests were RIGHT; only two of them needed the WebGL gate this file already uses for the R3F canvas. THE WORSE BUG THIS EXPOSED, which is why this is not just a `test.skip`: test('/chatt/ renders the atlas by default', ...) await expect(page.getByText('Atlas β')).toBeVisible() `Atlas β {slug}` renders UNCONDITIONALLY; the status line beside it is a ternary whose first branch is `error: ${error}`. So that test was GREEN, on firefox, on a completely dead atlas -- the probe above shows "Atlas β chatt" sitting directly beside "error: ...". The test whose whole job was proving the atlas renders could not fail when the atlas was broken. Same family as toBeVisible() ignoring occlusion (#299) and the placeholder client_id asserted toBeTruthy() (#288). The mount and the scene are different claims, so they are now different tests: the atlas MODULE mounts (no WebGL needed) unconditional, deliberately weak. Proves the Cesium chunk loaded and the module evaluated -- exactly what catches a #294-class dead vendor chunk, on every browser. the atlas SCENE initialises without erroring gated on WebGL. Asserts the HUD does NOT contain 'error:' and the chips exist. Verified RED for the right reason: with its skip removed on firefox, the SCENE test fails with Expected string: not "error:" Received string: "Atlas β chatt error: The browser supports WebGL, but initialization failed." i.e. it fails on the exact atlas the old test called green. Gate applied to only the two specs that need `ready` (the count, the type chip). The rest -- cannot-scroll, HUD width, cookie banner/PWA, contentinfo, the #299 wordmark -- pass on firefox WITHOUT WebGL and stay ungated, so they keep their signal on all three browsers. test.skip() is #288's false-green failure mode, so the gate stays narrow and chromium (swiftshader) still runs every real assertion on every PR. Verified on a CI-identical root build: firefox-gen 13 passed, 5 skipped, 0 failed (was: 2 failed) chromium-gen 20 passed, 0 skipped Closes #310
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #310. Found by the owner spotting a red shard on main.
main has been red for four runs
firefox-gen 6/6has failed on every main run sincea8ee9b4β #297's merge, when theatlas became the default. PR CI is chromium-only (firefox/webkit only run on push-to-main), so
#297 went in green and four more merges landed on top of a red main without anyone looking.
c6b7021a8ee9b4c2cadd077d464f8910cc1The cause is the environment, not the atlas
Probed with Playwright's Firefox against the real page:
Headless Firefox has no WebGL β Cesium's
Viewerctor throws βAtlasViewercatches it into itserror state β everything behind
{ready && β¦}(chips, count, legend) never renders. RealFirefox has WebGL. The tests were right; two of them just needed the WebGL gate this file
already uses for the R3F canvas.
The worse bug this exposed
Atlas β {slug}renders unconditionally β the status line beside it is a ternary whose firstbranch is
error: ${error}. The probe showsAtlas β chattsitting directly beside the error.So the test whose whole job was proving the atlas renders was green, on Firefox, on a
completely dead atlas. It could not fail when the product was broken. Same family as
toBeVisible()ignoring occlusion (#299) and the placeholderclient_ida test assertedtoBeTruthy()on (#288).The fix: the mount and the scene are different claims, so they're different tests
error:and the chips exist. Cannot pass on a dead atlas.Verified RED for the right reason β skip removed, run on Firefox's genuinely dead atlas:
It fails on the exact atlas the old test called green.
The gate is deliberately narrow
test.skip()is #288's false-green failure mode, so only the two specs that needreadyaregated (the building count, the type chip). Everything else β cannot-scroll, HUD width, cookie
banner/PWA, contentinfo, the #299 wordmark β passes on Firefox without WebGL and stays
ungated, keeping its signal on all three browsers. Chromium has swiftshader, so every real
assertion still runs on every PR.
The building count test is not loosened: it's the one that catches "0 buildings" over a
correct 8031-building legend, which has shipped once.
Verified on a CI-identical root build