chore(#275): remove the dead builder/runner Dockerfile stages#319
Merged
Conversation
ScriptHammer deploys as a static export (output: 'export' → out/ on GitHub Pages), so there is no long-running Node server image. The 'runner' stage copied .next/standalone — which output: 'export' never emits — so it could never build, and nothing targets it (the 'builder' compose service uses target: dev and runs 'pnpm build' as a command). The 'builder' stage existed only to feed 'runner'. Remove both dead stages (the Dockerfile now ends at 'dev') and update the docker-compose builder-service comment that referenced them. Validated: compose parses, 'docker build --check --target dev' clean. One item of the #275 docker audit; the rest (secrets block, tini, .dockerignore) remain. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #275 (docker best-practices audit). Removes the dead
builder+runnerDockerfile stages.Why they're dead
ScriptHammer deploys as a static export (
output: 'export'→out/on GitHub Pages), so there is no long-running Node server image:runnercopied.next/standalone, whichoutput: 'export'never emits → the stage could never build.runner(notarget: runnerin compose/CI/scripts); thebuildercompose service usestarget: devand runspnpm buildas a command.builderDockerfile stage existed only to feedrunner.Change
devstage (base → deps → dev); deadbuilder/runnerremoved, with a NOTE explaining why there's no prod server image.builder-service comment that referenced the removed stages.Validation
docker compose config -q→ validdocker build --check --target dev→ "Check complete, no warnings found"from=builder/AS runnerreferencesScope: the "delete dead runner stage" item of #275. Remaining audit items (demo-secrets → compose
secrets:,tini, broaden.dockerignore) stay open on #275.🤖 Generated with Claude Code