fix: nav active-state reflects the map renderer (Diorama vs Atlas), not just pathname#335
Merged
Merged
Conversation
…just pathname usePathname() ignores the query, so both map links resolve to /chatt and the active-state lit up 'Atlas' even while the diorama (?diorama) was showing. Base the highlight on the actual renderer via selectRenderer(window.location.search), read client-side (mount flag) to avoid a hydration mismatch — the map links full-navigate, so the nav re-mounts and re-reads on every switch. Other nav items keep the pathname-based active check. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #334.
usePathname()is query-blind, so both map links resolve to/chattand 'Atlas' stayed highlighted even on the diorama. The highlight now reflects the actual renderer (selectRenderer(window.location.search), read client-side behind a mount flag to avoid a hydration mismatch; the map links full-navigate so the nav re-mounts and re-reads on each switch). Verified locally: on?diorama, Diorama is the active item (desktop + mobile);/chattkeeps Atlas active. type-check + lint green.