fix(auth): honor X-Forwarded-Proto for reset/invite links and email o… - #42
Merged
Merged
Conversation
…rigin req.protocol reflects the socket the app sees, not the client's real scheme. Behind a TLS-terminating reverse proxy that forwards plain HTTP to the app, forgot-password links, invite links, and the SMTP-test email's logo origin all rendered as http://. oidc.js and recipes.js already check x-forwarded-proto/x-forwarded-host before falling back to req.protocol; apply the same pattern in auth.js and app-config.js. Symptom: invite emails containing an http:// link and an http:// embedded image got flagged as spam by mail providers. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…rigin
req.protocol reflects the socket the app sees, not the client's real scheme. Behind a TLS-terminating reverse proxy that forwards plain HTTP to the app, forgot-password links, invite links, and the SMTP-test email's logo origin all rendered as http://. oidc.js and recipes.js already check x-forwarded-proto/x-forwarded-host before falling back to req.protocol; apply the same pattern in auth.js and app-config.js.
Symptom: invite emails containing an http:// link and an http:// embedded image got flagged as spam by mail providers.