Align lockdown troubleshooting text with actual behaviour (#743) - #745
Merged
Conversation
Remove the promise of a lockdown-detection notification from troubleshooting_alwayson_desc: no such notification is ever posted, and on Android S+ the condition cannot be detected by non-system apps at all. Drop the unreferenced title_lockdown_enabled string, and document in ActivityMain that the enable-time lockdown check is deliberately limited to pre-S devices, with onboarding and the troubleshooting page as the only S+ coverage. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GTx9x5FNwfkVpNfJmWiqWT
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the actionable half of #743 (part 2), and documents the decision on part 1.
troubleshooting_alwayson_descno longer claims "A notification will appear if this is detected" — no such notification is posted anywhere, and on Android S+ the lockdown condition cannot be detected by non-system apps at all.title_lockdown_enabledstring (defined, never referenced). Only the sourcevalues/strings.xmlis touched; Crowdin sync will drop the stale translations.SDK_INT < Sguard inActivityMainto record that the missing S+ enable-time check is deliberate, with onboarding and the troubleshooting page as the remaining coverage — so part 1 of Lockdown warning has an Android S+ blind spot, and the promised notification does not exist #743 can be closed as a decision rather than rediscovered.Validation: XML well-formedness checked and no remaining
title_lockdown_enabledreferences inapp/src. No Android SDK is available in this environment, socompileGithubDebugJavaWithJavaccould not be run — the Java change is a comment only.🤖 Generated with Claude Code
https://claude.ai/code/session_01GTx9x5FNwfkVpNfJmWiqWT
Generated by Claude Code