CI: CI is broken on current GitHub runner images and JUCE develop (plan) - #408
Closed
drowaudio wants to merge 1 commit into
Closed
CI: CI is broken on current GitHub runner images and JUCE develop (plan)#408drowaudio wants to merge 1 commit into
drowaudio wants to merge 1 commit into
Conversation
…ages and JUCE develop
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #408 +/- ##
========================================
Coverage 58.74% 58.74%
========================================
Files 564 564
Lines 78879 78879
Branches 12330 12328 -2
========================================
+ Hits 46338 46339 +1
+ Misses 32541 32540 -1 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem summary
Every failure listed in #407 was observed on
master(last commit 2025-08-22, JUCE 8.0.6, v3.2.0) or on a branch based on it (#405 hasb0c7dd0, themastertip, as its merge-base).developis 404 commits ahead (JUCE 8.0.13, v3.5.0) and already contains a fix for every item. Both theBuildandjuce_compatabilityworkflows are fully green on the currentdeveloptipb88a6ee(runs 33712203414 and 33705363025, 2026-09-03, every matrix jobsuccess).So this is not a code problem on
develop. It is a branch-hygiene problem:masterhas not received a release since v3.2 and no longer builds on current runner images, and #405 inherits that by targeting it.Item-by-item status on
developdevelop_LIBCPP_ENABLE_ASSERTIONSremoved (macOS Debug)37c894f)c622448cc98 Updated juce, macOS Debug jobs green-Wimplicit-int-float-conversionunder-Werror(macOS Release)bbdcc40650a Added some explicit casts to keep the latest clang version happyDitherer.h:24value changeamp = invWordLen / (float) RAND_MAX;. The "2147483647 to 2147483648" rounding is inherent to representingRAND_MAXin float and only affects the dither amplitude scale by ~5e-8 relative. No behavioural change is needed.juce_VST3PluginFormat.cpp/wd4458was needed.c622448cc98Xcode_15.3.apppin822e8b21a61 Use default Xcode version for juce_compat.yamlAudioFormat::createWriterForoverrideunique_ptr<OutputStream>&overload plususing juce::AudioFormat::createWriterFor;intracktion_FloatAudioFileFormat.h:38efcc05c4b5f Updated to latest juce (with AudioFormat API changesDrawableRectangleno longer aComponentComponentinexamples/common/Utilities.h:4116d02c924b07 Examples: Fixed JUCE 9 compatibilityJUCE_USE_CURL/JUCE_WEB_BROWSERredefined (gcc)juce_compatabilityjob green against JUCE develop (9.0.1)Affected files and modules
No source changes are proposed on
develop. The affected artefacts are branches:master(stale, needsdevelopmerged in or a release cut)bugfix/soundtouch-read-ahead-silence, basemaster)Step-by-step approach
develop. Either change the PR base todevelop(its diff will then be evaluated against current code; it will need a rebase because the merge-base is0a5f4e6from May 2025), or ask the author to rebase. Its CI will then run with the green toolchain.masterup to date. Mergedevelopintomaster(or fast-forward if a v3.5 release is intended). This is the only change that makesmaster's own scheduled runs green again and stops futuremaster-based PRs from hitting the same wall. This is a maintainer action and not something to do from a bugfix branch.CONTRIBUTING/READMEthat PRs targetdevelop, and consider a GitHub branch-protection or a tiny workflow that fails PRs opened againstmasterunless they are release PRs. Nothing else in the CI config needs changing.masterbuilds green, or close it now as "fixed on develop" with the pointer to step 2.Edge cases and tests
develop.Ditherer.hquestion raised in the issue was checked: the cast only changes the dither noise amplitude at the 1e-8 relative level; no test or behaviour change warranted.masteris merged forward, the scheduledBuildandjuce_compatabilityruns onmasterwill confirm the fix without any manual step.Complexity
Small. No code change; one branch merge and one PR retarget.
Open questions for the maintainer
masterbe updated by mergingdevelopnow (implying a v3.5.0 release), or ismasterintentionally frozen at v3.2 until a later release?develop, or ask the author to rebase and re-open?master? If yes, this branch can carry that workflow change; otherwise this draft PR can be closed without merging.Fixes #407