Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ PR 유형
✨ [Feat]
🛠️ 작업 내용
job_rationales)를job_id로 바인딩, 없으면 직무 영역 단락으로 안전 폴백track_rationales)를combo_key로 바인딩하고 조합 내 트랙 위치(A/B)별로 구분, 없으면 트랙 영역 단락으로 폴백combo_rationale)를 개별 트랙 근거와 분리해 조합 reasoning 으로 노출JobRationale,TrackRationale) +Explanation필드 추가track_arationale로 매핑하는 문제를@JsonProperty("track_a_rationale")로 고정(B 동일)@Tag("e2e"), 서버 미기동 시 자동 스킵)📋 추후 진행 상황
📌 리뷰 포인트
service/— 항목별 근거 바인딩·폴백 우선순위(직무job_id/ 트랙combo_key+위치 → 없으면 영역 단락) 로직 정합성ai/(DTO) — snake_case 매핑 고정(@JsonProperty)이 AI 와이어 필드명과 일치하는지src/test/— e2e 는 외부 AI 서버 의존이라 미기동 환경에서 스킵 처리되는 점(CI 실패 아님)🔗 관련 이슈
Closes #63
📸 스크린샷
(해당 없음 — 백엔드 변경)
✅ 체크리스트
./gradlew spotlessApply로 포매팅 적용./gradlew spotlessCheck통과./gradlew checkstyleMain checkstyleTest통과./gradlew build성공./gradlew test모든 테스트 통과