Standardize optional Session runtime projection - #987
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Root cause
Login-backed runtimes used a UI resolver branch that always preferred detected Workspace metadata, even after the user explicitly selected another credential. Separately, legacy resume identities without a persisted binding were reconstructed from mutable Workspace files during resume/WebPi/headless activation, so their effective provider could change after Session creation.
Impact
New and resumed Sessions now have stable, truthful process-level runtime inputs. A native binding may omit OpenAlice credentials entirely while still carrying model/effort overrides, and remembered explicit provider choices stay visible and are submitted atomically.
Verification
npx tsc --noEmitpnpm -C ui exec tsc -bpnpm test: 3946 tests executed; nine unrelated parallel-load timeouts, all nine passed on immediate focused rerun (49/49)pnpm devbrowser walk: GLM Workspace -> DeepSeek showsdeepseek-v4-flash, Session-only ownership copy, and matching Manager model/effortCSC_IDENTITY_AUTO_DISCOVERY=false pnpm electron:smoke:workspace(packaged managed-Pi scheduled Issue acceptance passed and cleaned up)