Skip to content

Allow no null byte on WKT - #8

Merged
ryanstocks00 merged 2 commits into
mainfrom
null-byte
Jun 7, 2026
Merged

Allow no null byte on WKT#8
ryanstocks00 merged 2 commits into
mainfrom
null-byte

Conversation

@ryanstocks00

Copy link
Copy Markdown
Contributor

No description provided.

@codacy-production

codacy-production Bot commented Jun 7, 2026

Copy link
Copy Markdown

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 2 duplication

Metric Results
Complexity 0
Duplication 2

View in Codacy

NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.

@ryanstocks00
ryanstocks00 force-pushed the null-byte branch 2 times, most recently from 57eb4b2 to 97f667e Compare June 7, 2026 03:17
@codecov

codecov Bot commented Jun 7, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.

Flag Coverage Δ
unittests 93.30% <100.00%> (+0.12%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files with missing lines Coverage Δ
src/las_reader.hpp 87.11% <100.00%> (+1.79%) ⬆️
src/tests/test_reader.cpp 100.00% <100.00%> (ø)
src/vlr.hpp 36.23% <ø> (ø)
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves LAS WKT VLR parsing to handle files where the WKT payload is not NUL-terminated (some writers store WKT across the full record_length_after_header), and adds regression tests to cover both coordinate-system and math-transform WKTs in NUL-terminated and non-NUL-terminated forms.

Changes:

  • Parse OGC WKT VLR payloads (record_id 2111/2112) using las_packed_string(...) so the trailing NUL is optional.
  • Add reader tests for coordinate WKT (2112) and math-transform WKT (2111), with and without a trailing NUL, and for wkt() preference/fallback behavior.
  • Bump the pinned codecov/codecov-action SHA to the v7.0.0 release commit.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
src/vlr.hpp Clarifies that las_packed_string is also used for WKT payloads where a trailing NUL may be omitted.
src/las_reader.hpp Uses las_packed_string when decoding WKT VLR payloads to support both terminated and unterminated payloads.
src/tests/test_reader.cpp Adds regression tests for WKT parsing across record_id 2111/2112 with/without trailing NUL and validates wkt() selection logic.
.github/workflows/codecov.yml Updates Codecov Action pin to the v7.0.0 commit SHA.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@ryanstocks00
ryanstocks00 merged commit a55eff6 into main Jun 7, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants