ライセンス画面に京王バスと東急バスのODPTライセンスを追記#6399
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Sqf7mKCpBJfJKpKczHrxN8
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
📝 WalkthroughWalkthrough京王バスと東急バスの翻訳キーを英語・日本語リソースに追加し、ライセンス画面に各社のサイトリンクとODPT基本ライセンス情報を表示する項目を追加しました。 Changesバス事業者ライセンス
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
This was referenced Jul 12, 2026
Merged
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
京王バスと東急バスのODPT GTFSデータを新たに利用するため、ライセンス画面に2社のODPTライセンス表記を追加しました。
変更の種類
変更内容
src/screens/Licenses.tsx)に「京王バス」「東急バス」のライセンス項目を追加。西武バスと同じ公共交通オープンデータ基本ライセンス(odptBasicLicense/ODPT_BASIC_LICENSE_URL)を適用。LicenseId型にkeio_bus/tokyu_busを追加し、既存のバス事業者(西武バス)の直後に配置。ja.json:keioBus=京王バス /tokyuBus=東急バス、en.json: Keio Bus Co., Ltd. / Tokyu Bus Corporation)。補足: 両社の GTFS データセットは ODPT データカタログ(ckan.odpt.org)で
license_id=odpt-ptodbl(公共交通オープンデータ基本ライセンス)を指定しているため、函館市電の GTFS-RUL ではなく、既存の西武バスと同一のライセンスを適用しています。テスト
npm run lintが通ることnpm testが通ることnpm run typecheckが通ること関連Issue
スクリーンショット(任意)
Generated by Claude Code
Summary by CodeRabbit