初期画面のPull to Refreshの対象をプリセットカードより下の路線リストのみに限定#6412
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gu76E8vDn9ZheWEpmQj6Db
|
Warning Review limit reachedYou’ve reached a temporary PR review limit under our Fair Usage Limits Policy. Next review available in: 52 minutes Your organization has reached its usage spending cap. Adjust your spending cap in the billing tab. How can I continue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews. How do review limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability. For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window. Please refer docs for additional details. Review details⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
📝 WalkthroughWalkthrough
ChangesSelectLineScreenレイアウト
Estimated code review effort: 2 (Simple) | ~10 minutes Poem
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@src/screens/SelectLineScreen.tsx`:
- Around line 304-336: Update the root layout around the styles.root View in
SelectLineScreen to preserve horizontal safe-area insets while leaving vertical
insets to the overlay handling. Use SafeAreaView or equivalent with only the
left and right edges enabled, ensuring presets and the scrollable line list
remain protected from side notches on landscape and tablet layouts.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: CHILL
Plan: Pro
Run ID: 9824500e-081f-494d-bd2e-41b8c234e421
📒 Files selected for processing (2)
src/screens/SelectLineScreen.render.test.tsxsrc/screens/SelectLineScreen.tsx
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Gu76E8vDn9ZheWEpmQj6Db
概要
初期画面(路線選択画面)の Pull to Refresh の対象を、プリセットカードより下の路線リストだけに限定しました。従来は画面全体が単一のスクロールビューで
RefreshControlを保持していたため、プリセットカード上を含め画面のどこを下に引っ張っても最寄り駅の再取得が発火していました。変更の種類
変更内容
NowHeader直下に固定表示する独立領域へ切り出し、スクロール/Pull to Refresh の対象外にしたRefreshControl付きのAnimated.ScrollViewに配置し、Pull to Refresh の対象をそこだけに限定したRefreshControlのprogressViewOffsetを削除NowHeader/FooterTabBar(いずれも絶対配置オーバーレイ)に委ねられるためSafeAreaViewを通常のViewに変更(フルブリードのカルーセル・カードの 24px ガター・フッター分の下端余白は維持)テスト
npm run lintが通ることnpm testが通ることnpm run typecheckが通ること関連Issue
スクリーンショット(任意)
Generated by Claude Code
Summary by CodeRabbit