Remove 9-parameter private constructor from Address record

[Copilot]

Codacy flagged Address::Address for exceeding the 8-parameter complexity limit. The private constructor existed solely to support the Create factory method.

Changes

• Removed the 9-parameter private constructor
• Switched all properties from get; to get; init; so the Create method can use object initializer syntax
• Added private Address() { } to preserve encapsulation — external code cannot bypass Create validation via new Address { ... }

// Before
private Address(Guid addressId, String addressLine1, String? addressLine2,
                String? addressLine3, String? addressLine4, String town,
                String? region, String postalCode, String country) { ... }

// After — no constructor, init properties set via object initializer inside Create()
private Address() { }

return new Address
{
    AddressId = addressId,
    AddressLine1 = addressLine1,
    ...
};

The public Create factory method signature and all validation logic are unchanged.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

• f.feedz.io
  • Triggering command: /usr/bin/dotnet dotnet build TransactionProcessor.Models/TransactionProcessor.Models.csproj --no-restore -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test TransactionProcessor.Tests/TransactionProcessor.Tests.csproj --no-restore -nologo (dns block)
  • Triggering command: /usr/bin/dotnet dotnet test TransactionProcessor.BusinessLogic.Tests/TransactionProcessor.BusinessLogic.Tests.csproj --filter MerchantDomainService_ --no-restore -nologo (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

• Configure Actions setup steps to set up my environment, which run before the firewall is enabled
• Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

[codacy-production]

Up to standards ✅

🟢 Issues 0 issues

Results:
0 new issues

View in Codacy

🟢 Metrics 0 complexity · 0 duplication

Metric	Results
Complexity	0
Duplication	0

View in Codacy

_{TIP This summary will be updated as you push new changes. Give us feedback}