Skip to content

Remove 9-parameter private constructor from Address record #1720

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
StuartFerguson merged 3 commits into from
Apr 8, 2026
Merged

Remove 9-parameter private constructor from Address record #1720

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
794b07b
Initial plan
Copilot Apr 7, 2026
6061fe7
Fix Address constructor parameter count: remove 9-param private ctor,…
Copilot Apr 7, 2026
20b6c9d
Merge branch 'master' into copilot/fix-address-method-parameters
StuartFerguson Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 22 additions & 30 deletions TransactionProcessor.Models/Merchant/Address.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,36 +4,17 @@ namespace TransactionProcessor.Models.Merchant
{
public record Address
{
public Guid AddressId { get; }
public String AddressLine1 { get; }
public String? AddressLine2 { get; }
public String? AddressLine3 { get; }
public String? AddressLine4 { get; }
public String Town { get; }
public String? Region { get; }
public String PostalCode { get; }
public String Country { get; }
public Guid AddressId { get; init; }
public String AddressLine1 { get; init; }
public String? AddressLine2 { get; init; }
public String? AddressLine3 { get; init; }
public String? AddressLine4 { get; init; }
public String Town { get; init; }
public String? Region { get; init; }
public String PostalCode { get; init; }
public String Country { get; init; }

private Address(Guid addressId,
String addressLine1,
String? addressLine2,
String? addressLine3,
String? addressLine4,
String town,
String? region,
String postalCode,
String country)
{
AddressId = addressId;
AddressLine1 = addressLine1;
AddressLine2 = addressLine2;
AddressLine3 = addressLine3;
AddressLine4 = addressLine4;
Town = town;
Region = region;
PostalCode = postalCode;
Country = country;
}
private Address() { }

public static Address Create(Guid addressId,
String addressLine1,
Expand All @@ -57,7 +38,18 @@ public static Address Create(Guid addressId,
if (String.IsNullOrWhiteSpace(country))
throw new ArgumentException("Country is required");

return new Address(addressId, addressLine1, addressLine2, addressLine3, addressLine4,town, region, postalCode, country);
return new Address
{
AddressId = addressId,
AddressLine1 = addressLine1,
AddressLine2 = addressLine2,
AddressLine3 = addressLine3,
AddressLine4 = addressLine4,
Town = town,
Region = region,
PostalCode = postalCode,
Country = country
};
}
}
}
Loading