Cache and gen#13
Merged
Merged
Conversation
anshradh
marked this pull request as ready for review
September 16, 2022 21:11
anshradh
marked this pull request as draft
September 16, 2022 21:20
anshradh
marked this pull request as ready for review
September 16, 2022 22:03
added 8 commits
September 18, 2022 14:07
anshradh
force-pushed
the
cache_and_gen
branch
from
September 18, 2022 21:10
8c3fb6c to
e22930a
Compare
Collaborator
|
Thanks and sorry for taking so long on this! Did a bunch of refactoring and integration into my new changes, and just merged in :) |
Collaborator
Author
|
No worries and sorry for not keeping it more up-to-date! |
arthurdupe
pushed a commit
to ArthurConmy/TransformerLens
that referenced
this pull request
Jul 30, 2023
…edge-dumping Arthur add edge dumping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This has working implementations of sampling (with various modifications to logits, i.e. temperature, top-k, top-p, etc.) and greedy decoding, both with and without caching past keys and values (cache offers 3-4x speedup). These are also all batched. Will put up a PR for beam search next